Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuing to refine the logging #2920

Merged
merged 1 commit into from
Jan 18, 2024
Merged

continuing to refine the logging #2920

merged 1 commit into from
Jan 18, 2024

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Jan 18, 2024

WHAT DOES THIS PR DO?

  • continuing to refine the logging

HOW DO I TEST OUT THIS PR?

cd src/device-registry
npm install
npm run dev-mac

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

  • add events

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (09103af) 30.97% compared to head (7ce78ee) 30.97%.
Report is 2 commits behind head on staging.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #2920   +/-   ##
========================================
  Coverage    30.97%   30.97%           
========================================
  Files          184      184           
  Lines        23813    23813           
  Branches      3055     3055           
========================================
  Hits          7377     7377           
  Misses       16319    16319           
  Partials       117      117           
Files Coverage Δ
src/device-registry/controllers/create-event.js 1.76% <0.00%> (ø)
src/device-registry/utils/create-event.js 16.20% <0.00%> (ø)

Copy link
Contributor

Device registry changes in this PR available for preview here

@Baalmart Baalmart merged commit 0733a27 into staging Jan 18, 2024
47 of 48 checks passed
@Baalmart Baalmart deleted the downtime-email-alerts branch January 18, 2024 16:34
@Baalmart Baalmart mentioned this pull request Jan 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant