hotfix to emphasize the update or addition of records #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## staging #2926 +/- ##
===========================================
- Coverage 30.98% 30.97% -0.01%
===========================================
Files 184 184
Lines 23812 23815 +3
Branches 3055 3055
===========================================
Hits 7377 7377
- Misses 16318 16321 +3
Partials 117 117
|
Baalmart
commented
Jan 19, 2024
| const res = await ReadingModel("airqo").updateOne(doc, doc, { | ||
| upsert: true, | ||
| }); | ||
| const filter = { site_id: doc.site_id, time: doc.time }; |
There was a problem hiding this comment.
Explicitly stating the filter we shall use for the update operations. Previous version was using all the fields to filter which also included the _id field from the Events collection yet we are busy inserting in a completely new collection (Readings)! @BenjaminSsempala
|
Device registry changes in this PR available for preview here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT DOES THIS PR DO?
hotfix to emphasize the update or addition of records
Idempotency: Design the function (inside the
/bin/store-readings-job job) to be idempotent. This means that even if it's run multiple times, it won't produce different results. For example, instead of inserting records into the database, the function could update them, leaving existing records unchanged.We have been noticing Duplicate errors in the K8S logs yet we are using a mongoose update operation, things were not adding up!
Additionally, we noticed some differences in the measurements for staging and production for the same site at the same time --- we think this fix could help to rectify this issue too.
HOW DO I TEST OUT THIS PR?