Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing BCC emails from inquiries #4377

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Feb 6, 2025

Description

removing BCC emails from inquiries

Changes Made

  • removing BCC emails from inquiries

Testing

  • Tested locally
  • Tested against staging environment
  • Relevant tests passed: [List test names]

Affected Services

  • Which services were modified:
    • Auth Service

Endpoints Ready for Testing

  • New endpoints ready for testing:
    • Post Inquiry

API Documentation Updated?

  • Yes, API documentation was updated
  • No, API documentation does not need updating

Summary by CodeRabbit

  • Bug Fixes
    • Streamlined inquiry emails to ensure they are sent only to designated recipients, enhancing recipient privacy by removing additional, undisclosed notifications.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

📝 Walkthrough

Walkthrough

The change removes the line that sets the bcc field in the mailOptionsForAirQo object within the inquiry method of the mailer utility. As a result, inquiry emails no longer include BCC recipients, altering how recipient visibility is managed. No other modifications were made to the method or its error handling.

Changes

File Change Summary
src/auth-service/utils/common/mailer.js Removed the BCC field (subscribedBccEmails) from the inquiry email options in the mailer method.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Mailer
    participant SMTP
    Client->>Mailer: Send inquiry request
    Mailer->>SMTP: Construct email (without BCC)
    SMTP-->>Mailer: Email sent confirmation
    Mailer-->>Client: Return response
Loading

Possibly related PRs

Poem

In the code’s realm, a change takes flight,
BCC is gone, now out of sight.
Inquiry emails with a cleaner vibe,
An elegant shift in the coder’s tribe.
Cheers to progress, smooth and bright! 🚀📧

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e4284e and 9711a52.

📒 Files selected for processing (1)
  • src/auth-service/utils/common/mailer.js (0 hunks)
💤 Files with no reviewable changes (1)
  • src/auth-service/utils/common/mailer.js
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build-push-deploy-auth-service
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.21%. Comparing base (208e702) to head (9711a52).
Report is 5 commits behind head on staging.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #4377   +/-   ##
========================================
  Coverage    11.21%   11.21%           
========================================
  Files          156      156           
  Lines        17985    17985           
  Branches       388      388           
========================================
  Hits          2017     2017           
  Misses       15966    15966           
  Partials         2        2           
Files with missing lines Coverage Δ
src/auth-service/utils/common/mailer.js 2.43% <ø> (ø)

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Auth-service changes in this PR available for preview here

@Baalmart Baalmart merged commit f4f1f01 into staging Feb 6, 2025
52 checks passed
@Baalmart Baalmart deleted the remove-bbc-inquiries branch February 6, 2025 11:27
@Baalmart Baalmart mentioned this pull request Feb 6, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant