Enhancement: Update Developer Inquiry Email #4387
Conversation
📝 WalkthroughWalkthroughThe update modifies the field_activity method in the email messages utility by adding an activityType parameter with a default value of "recall". The method now conditionally generates the email message content based on whether the activityType indicates a recall or a deployment. The core structure of the method remains unchanged while its logic for message generation becomes dynamic. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant EmailMsgs
Caller->>EmailMsgs: Call field_activity(parameters, activityType)
EmailMsgs->>EmailMsgs: Check activityType value
alt activityType == "recall"
EmailMsgs-->>Caller: Return "recall" email message
else other value
EmailMsgs-->>Caller: Return "deployment" email message
end
Possibly related PRs
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #4387 +/- ##
========================================
Coverage 11.21% 11.21%
========================================
Files 156 156
Lines 17968 17968
Branches 388 388
========================================
Hits 2015 2015
Misses 15951 15951
Partials 2 2
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/auth-service/utils/common/email.msgs.js (1)
164-164: Consider moving the Google form URL to constants.While the form link addition is good, hardcoding URLs can make maintenance difficult. Consider moving this URL to the constants file for better maintainability.
- <p>To contribute to our open-source community as a software engineer, please fill out this <a href="https://docs.google.com/forms/d/e/1FAIpQLSc7xixPoIo65pe6mlbNVB8jM5F4ZKCz87SmQTY412XbsqWrLQ/viewform?usp=dialog">form</a>.</p> + <p>To contribute to our open-source community as a software engineer, please fill out this <a href="${constants.OPENSOURCE_FORM}">form</a>.</p>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/auth-service/utils/common/email.msgs.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build-push-deploy-auth-service
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
src/auth-service/utils/common/email.msgs.js (1)
438-482: LGTM! Well-structured enhancement to the field activity notification.The changes effectively implement dynamic messaging based on activity type while maintaining backward compatibility with the default "recall" value. The code is clean and well-organized.
|
Auth-service changes in this PR available for preview here |
Description
This PR updates the email content sent to developers who inquire about contributing to AirQo. It adds a link to the Google form for joining the open-source community and removes the contact information for the Software Engineering Lead
Changes Made
Testing
Affected Services
Endpoints Ready for Testing
API Documentation Updated?
Summary by CodeRabbit