Update/calculate hourly airqualitydata using bigqdata

[NicholasTurner23]

Description

• Fix unset persistent variable
• Method docs

Summary by CodeRabbit

• Refactor
  • Enhanced date handling and time calculations to improve reliability and clarity in scheduling operations.
• Bug Fixes
  • Adjusted the hourly data extraction workflow to ensure accurate and consistent timestamp updates for smoother data processing.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request enhances the type safety in the DateUtils class by adding explicit type hints to class attributes and method parameters. Additionally, it refines the control flow in the data extraction DAG by introducing a conditional check in the extract_hourly_data task and updating the new_date_2021 variable accordingly, followed by an increment after API calls in the send_hourly_measurements_to_api task.

Changes

File(s)	Change Summary
src/workflows/.../date.py	- Added explicit type hints (e.g., Optional[str], Optional[int], and Dict[str, Any]) for class attributes and method parameters. - Modified method signatures for date_to_str, get_dag_date_time_values, and get_query_date_time_values with improvements in parameter typing and reduced logic complexity.
src/workflows/.../airqo_measurements.py	- Introduced a conditional check in extract_hourly_data to set new_date_2021 if previous_date equals start. - Updated the send_hourly_measurements_to_api task to increment new_date_2021 by one hour after sending the API data.

Sequence Diagram(s)

sequenceDiagram
    participant Extract as extract_hourly_data
    participant API as send_hourly_measurements_to_api
    participant Var as new_date_2021

    Extract->>Var: Check if previous_date == start
    alt Condition met
        Var-->>Extract: Set new_date_2021 = previous_date
    else Condition not met
        Note over Extract: Continue without update
    end
    Extract->>API: Execute API call with new_date_2021
    API->>Var: Increment new_date_2021 by 1 hour

Loading

Suggested reviewers

• Baalmart
• Psalmz777

Poem

In the code's quiet halls, clarity takes flight,
Type hints sparkle gently in the soft debug light.
Conditional paths realign with grace,
Data flows anew in its clean, measured pace.
A dance of logic and code, bold and bright!
🚀 Happy coding!

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f710d9c and bc42d55.

📒 Files selected for processing (2)

• src/workflows/airqo_etl_utils/date.py (3 hunks)
• src/workflows/dags/airqo_measurements.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript)

🔇 Additional comments (5)

src/workflows/airqo_etl_utils/date.py (4)

2-2: LGTM! Well-organized type imports.

The addition of type imports from the typing module is clean and follows Python's standard library organization.

---

10-12: LGTM! Clear and consistent type hints for class attributes.

The addition of type hints to the datetime format string constants improves code clarity and maintainability.

---

15-15: LGTM! Comprehensive type hints for method signature.

The type hints for parameters and return value are accurate and align well with the method's implementation.

---

86-88: LGTM! Well-defined type hints for complex method signature.

The type hints accurately capture the method's parameter types and return value, improving code clarity and type safety.

src/workflows/dags/airqo_measurements.py (1)

668-669: LGTM! Proper initialization of persistent variable.

The conditional check ensures that the new_date_2021 variable is properly initialized only when needed, fixing the unset persistent variable issue mentioned in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Baalmart]

thanks @NicholasTurner23