Update/calculate hourly airqualitydata using bigqdata

[NicholasTurner23]

Description

Just some cleanup

Summary by CodeRabbit

• Chores

  • Improved system configuration by ensuring a reliable default setting is applied when no calibration value is provided.

• Refactor

  • Consolidated the data processing workflow for message delivery across automated tasks, enhancing consistency and error handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request updates the configuration and data processing flow. It sets a default value for the CALIBRATEBY variable in the configuration to "country". In addition, it removes the static method process_data_for_message_broker from the DataValidationUtils class and introduces a new implementation of the same function in the DataUtils class. Correspondingly, multiple DAGs are modified to call the method from DataUtils instead of DataValidationUtils.

Changes

Files	Change Summary
src/workflows/airqo_etl_utils/config.py	Updated retrieval of CALIBRATEBY to default to "country" if the environment variable is not set.
src/workflows/airqo_etl_utils/data_validator.py	Removed the static method process_data_for_message_broker from the DataValidationUtils class.
src/workflows/airqo_etl_utils/datautils.py	Added a new static method process_data_for_message_broker with logic to process data for message broker consumption, including data transformation and error handling.
src/workflows/dags/...	Replaced calls from DataValidationUtils.process_data_for_message_broker to DataUtils.process_data_for_message_broker in several DAG files.

Sequence Diagram(s)

sequenceDiagram
    participant DAG as DAG Task
    participant DU as DataUtils
    participant DB as Devices Data

    DAG->>DU: process_data_for_message_broker(data, frequency)
    DU->>DU: Format DataFrame and convert timestamps
    DU->>DB: Retrieve device information (get_devices)
    DU->>DU: Rename columns and merge data
    DU-->>DAG: Return processed DataFrame (or error)

Loading

Possibly related PRs

• Update/calculate hourly airqualitydata using bigqdata #4482: Involves similar changes to the CALIBRATEBY variable in the config.py file, indicating a coordinated update in configuration handling.

Suggested reviewers

• Baalmart
• BenjaminSsempala

Poem

Code now flows in a refined stream,
Defaults in place, crisp as a dream.
Data shifts from old hands to new,
With every merge, the logic grew.
From config to DAG, our code takes flight,
In harmony, it shines so bright.
Cheers to progress and coding delight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6408611 and fd64459.

📒 Files selected for processing (7)

• src/workflows/airqo_etl_utils/config.py (1 hunks)
• src/workflows/airqo_etl_utils/data_validator.py (0 hunks)
• src/workflows/airqo_etl_utils/datautils.py (1 hunks)
• src/workflows/dags/airnow.py (3 hunks)
• src/workflows/dags/airqo_bam_measurements.py (1 hunks)
• src/workflows/dags/airqo_measurements.py (3 hunks)
• src/workflows/dags/kcca_measurements.py (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.34%. Comparing base (f84eeba) to head (fd64459).
Report is 5 commits behind head on staging.

Additional details and impacted files

@@             Coverage Diff             @@
##           staging    #4484      +/-   ##
===========================================
- Coverage    11.23%   10.34%   -0.90%     
===========================================
  Files          156       56     -100     
  Lines        18020     5490   -12530     
  Branches       388      388              
===========================================
- Hits          2025      568    -1457     
+ Misses       15993     4920   -11073     
  Partials         2        2              

see 100 files with indirect coverage changes