Update/calculate hourly airqualitydata using bigqdata

[NicholasTurner23]

Description

Just some cleanup

Summary by CodeRabbit

• Refactor
  • Enhanced the calibration process to improve data handling and reliability.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change refactors the calibrate_data method in airqo_utils.py. The conditional check for the variable groupedby now ensures the value is truthy (i.e., not None or an empty string) and that it is not NaN using pd.isna, before verifying membership in available_models. This update enhances the robustness of the data calibration logic.

Changes

File	Description
src/.../airqo_utils.py	Updated calibrate_data method to check if groupedby is truthy and not NaN (using pd.isna) in addition to confirming its membership in available_models.

Possibly related PRs

• Update/calculate hourly airqualitydata using bigqdata #4351: Addresses similar changes in the calibrate_data method by updating the logic and data handling conditions.

Suggested reviewers

• Baalmart

Poem

In code we trust, in checks we refine,
A truthy guard for our data line.
With pd.isna our path is clear,
No empty strings shall ever appear.
Robust and neat, our logic sings,
Bringing light to useful things.
🚀 Happy coding!

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/workflows/airqo_etl_utils/airqo_utils.py (1)

670-674: Improvement to NaN detection logic.

The change from np.isnan(groupedby) == False to not pd.isna(groupedby) strengthens the code by using Pandas' more robust missing value detection. This handles various missing value types (None, NaN, NA) across different data types, not just numeric ones.

For even more robustness, consider adding a type check before calling .lower() to prevent potential AttributeError exceptions:

if (
    groupedby
    and not pd.isna(groupedby)
+   and isinstance(groupedby, str)
    and groupedby.lower() in available_models
):

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8111a1 and 99e8f1b.

📒 Files selected for processing (1)

• src/workflows/airqo_etl_utils/airqo_utils.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)