Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBSITE] French Translation for all static pages #1704

Merged
merged 29 commits into from
Feb 6, 2024
Merged

[WEBSITE] French Translation for all static pages #1704

merged 29 commits into from
Feb 6, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Nov 17, 2023 •
edited
Loading

Summary of Changes (What does this PR do?)

  • This PR completes the French translation for all static content on the website including those of the clean air site.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image

@OchiengPaul442 OchiengPaul442 self-assigned this Nov 17, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91e6372) 9.41% compared to head (170c24e) 37.58%.
Report is 9 commits behind head on staging.

❗ Current head 170c24e differs from pull request most recent head 1dcc923. Consider uploading reports for the commit 1dcc923 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           staging    #1704       +/-   ##
============================================
+ Coverage     9.41%   37.58%   +28.17%     
============================================
  Files          224       59      -165     
  Lines        12283      596    -11687     
  Branches       116      115        -1     
============================================
- Hits          1156      224      -932     
+ Misses       11110      355    -10755     
  Partials        17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

Baalmart
Baalmart reviewed Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OchiengPaul442 , please share the deploy preview with Priscah for review. Let me share her WhatsApp number with you. When you share, tell her more context so she knows what to do ---- do not just share without any caption. Thanks!

@OchiengPaul442
Copy link
Contributor Author

okay

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@OchiengPaul442 OchiengPaul442 changed the title [WEBSITE] French Translation for products pages [WEBSITE] French Translation for all static pages Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

New Website changes available for preview here

@Baalmart Baalmart merged commit 825ba4f into staging Feb 6, 2024
25 of 27 checks passed
@Baalmart Baalmart deleted the website-French-translation branch February 6, 2024 20:53
@Baalmart Baalmart mentioned this pull request Feb 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart left review comments

@FaithDaka FaithDaka Awaiting requested review from FaithDaka

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OchiengPaul442 @Baalmart