Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB] CleanAir about page redesign #1809

Merged
merged 5 commits into from
Jan 16, 2024
Merged

[WEB] CleanAir about page redesign #1809

merged 5 commits into from
Jan 16, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Jan 16, 2024

Summary of Changes (What does this PR do?)

  • Refactored code: Created a new, separate component to handle language switching functionality
  • Implemented the redesigned 'About' page for the Clean Air site as per the new design specifications

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image
image

@OchiengPaul442 OchiengPaul442 self-assigned this Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (61cfbe9) 8.06% compared to head (58d5ac3) 37.58%.
Report is 41 commits behind head on staging.

Files Patch % Lines
website/frontend/src/components/nav/TopBar.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           staging    #1809       +/-   ##
============================================
+ Coverage     8.06%   37.58%   +29.51%     
============================================
  Files          164       59      -105     
  Lines        11508      596    -10912     
  Branches         0      115      +115     
============================================
- Hits           928      224      -704     
+ Misses       10580      355    -10225     
- Partials         0       17       +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

New Website changes available for preview here

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OchiengPaul442 , this looks neat! :)

@Baalmart Baalmart merged commit d8ad1b3 into staging Jan 16, 2024
@Baalmart Baalmart deleted the Website-Design-upgrade branch January 16, 2024 07:24
@Baalmart Baalmart mentioned this pull request Jan 16, 2024
2 tasks
@OchiengPaul442 OchiengPaul442 restored the Website-Design-upgrade branch January 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants