Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Resolved collocation application error #1810

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[Hotfix] Resolved collocation application error #1810

merged 1 commit into from
Jan 16, 2024

Conversation

Codebmk
Copy link
Member

@Codebmk Codebmk commented Jan 16, 2024

Summary of Changes (What does this PR do?)

  • Added checks for if the collocationDevices variable exists to prevent undefined errors on the add monitor page

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

What are the relevant tickets?

Screenshots (optional)

image

@Codebmk Codebmk self-assigned this Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Baalmart
Baalmart approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Codebmk

@Baalmart Baalmart merged commit f07de67 into staging Jan 16, 2024
@Baalmart Baalmart deleted the hotfix-collocation-app-error branch January 16, 2024 07:26
@Baalmart Baalmart mentioned this pull request Jan 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

@OchiengPaul442 OchiengPaul442 Awaiting requested review from OchiengPaul442

Assignees

@Codebmk Codebmk

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codebmk @Baalmart