Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile App: Luganda Translations #1812

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Mobile App: Luganda Translations #1812

merged 5 commits into from
Jan 19, 2024

Conversation

BenjaminSsempala
Copy link
Contributor

Summary of Changes (What does this PR do?)

  • Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 190 lines in your changes are missing coverage. Please review.

Comparison is base (58d5ac3) 37.58% compared to head (2893c08) 7.94%.
Report is 14 commits behind head on staging.

Files Patch % Lines
mobile/lib/utils/custom_localisation.dart 1.61% 183 Missing ⚠️
mobile/lib/constants/language_constants.dart 0.00% 5 Missing ⚠️
...obile/lib/screens/analytics/analytics_widgets.dart 0.00% 1 Missing ⚠️
mobile/lib/screens/profile/profile_widgets.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging   #1812       +/-   ##
===========================================
- Coverage    37.58%   7.94%   -29.64%     
===========================================
  Files           59     165      +106     
  Lines          596   11692    +11096     
  Branches       115       0      -115     
===========================================
+ Hits           224     929      +705     
- Misses         355   10763    +10408     
+ Partials        17       0       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baalmart Baalmart merged commit 26c3820 into staging Jan 19, 2024
25 of 29 checks passed
@Baalmart Baalmart deleted the luganda branch January 19, 2024 09:52
@Baalmart Baalmart mentioned this pull request Jan 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants