Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email phone sync #1815

Merged
merged 27 commits into from
Feb 8, 2024
Merged

Email phone sync #1815

merged 27 commits into from
Feb 8, 2024

Conversation

katendejericho5
Copy link
Contributor

@katendejericho5 katendejericho5 commented Jan 17, 2024

Summary of Changes (What does this PR do?)

  • Allow users with phone numbers to connect their emails and obtain a platform account

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 354 lines in your changes are missing coverage. Please review.

Comparison is base (a1bd064) 37.90% compared to head (57ede27) 7.78%.

Files Patch % Lines
...ib/screens/email_link/confirm_account_details.dart 1.68% 117 Missing ⚠️
...ile/lib/screens/email_link/email_link_widgets.dart 4.85% 98 Missing ⚠️
mobile/lib/screens/email_link/email_link_page.dart 0.00% 58 Missing ⚠️
mobile/lib/screens/profile/profile_edit_page.dart 0.00% 24 Missing ⚠️
mobile/lib/screens/profile/profile_widgets.dart 0.00% 23 Missing ⚠️
...mail_authentication/email_verification_screen.dart 0.00% 21 Missing ⚠️
mobile/lib/screens/home_page.dart 0.00% 10 Missing ⚠️
mobile/lib/utils/custom_localisation.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging   #1815       +/-   ##
===========================================
- Coverage    37.90%   7.78%   -30.12%     
===========================================
  Files           59     168      +109     
  Lines          591   12035    +11444     
  Branches       116       0      -116     
===========================================
+ Hits           224     937      +713     
- Misses         350   11098    +10748     
+ Partials        17       0       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @katendejericho5 .

Awaiting QA test feedback from @BenjaminSsempala

@katendejericho5 katendejericho5 removed the request for review from noahnsimbe February 5, 2024 12:19
@BenjaminSsempala
Copy link
Contributor

thanks @katendejericho5 .

Awaiting QA test feedback from @BenjaminSsempala

Thanks @Baalmart
I've shared my QA feedback with Jericho on a call.

@Baalmart Baalmart merged commit 1446135 into staging Feb 8, 2024
25 of 29 checks passed
@Baalmart Baalmart deleted the email-phone-sync branch February 8, 2024 16:24
@Baalmart Baalmart mentioned this pull request Feb 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants