[Hotfix] Cohort dashoard charts and Visibility #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New netmanager changes available for preview here |
|
New netmanager changes available for preview here |
Baalmart
reviewed
Jan 22, 2024
| @@ -186,7 +186,7 @@ const CohortForm = ({ cohort }) => { | |||
| const initialState = { | |||
| name: '', | |||
| network: activeNetwork.net_name, | |||
| visibility: false | |||
| visibility: null | |||
There was a problem hiding this comment.
Hi @Codebmk , thanks for this.
- Is null the most appropriate default value for a Boolean field?
- Could you share some more insights behind this thought process of this hotfix?
There was a problem hiding this comment.
The default was initially false but that is not the case with the backend. If there's no visibility value, it is empty. Hence using null in the frontend. @Baalmart
There was a problem hiding this comment.
Okay @Codebmk . thanks for the clarifications. As long as things work as expected. Let us continue to study the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes (What does this PR do?)
nullif a device has no visibility value.Status of maturity (all need to be checked before merging):
Screenshots (optional)