Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Collocation page bug and thresholds error handling #1824

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Hotfix] Collocation page bug and thresholds error handling #1824

merged 1 commit into from
Jan 23, 2024

Conversation

Codebmk
Copy link
Member

@Codebmk Codebmk commented Jan 23, 2024

Summary of Changes (What does this PR do?)

  • Add error handling to the threshold input fields. Button for Schedule devices will remain disabled if the wrong thresholds are used.
  • Fixed application bug caused by wrong api field(was using data instead of devices)

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

How should this be manually tested?

  • On collocate page, click Add monitor button

Screenshots (optional)

image

@Codebmk Codebmk self-assigned this Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@Baalmart Baalmart merged commit 3fac4c2 into staging Jan 23, 2024
26 of 27 checks passed
@Baalmart Baalmart deleted the hotfix-collocation-app-error branch January 23, 2024 11:08
@Baalmart Baalmart mentioned this pull request Jan 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Awaiting requested review from Baalmart

@OchiengPaul442 OchiengPaul442 Awaiting requested review from OchiengPaul442

Assignees

@Codebmk Codebmk

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codebmk @Baalmart