Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE] changed to use grids endpoint and refactored api methods #1825

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Jan 23, 2024

Summary of Changes (What does this PR do?)

  • Implemented usage of Grids API endpoint
  • Refactored API methods and eliminated token usage

Purpose of this PR is to solve the issue of tokens leaking in the frontend of website.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change is ready to hit production in its current state.

image

@OchiengPaul442 OchiengPaul442 self-assigned this Jan 23, 2024
@OchiengPaul442 OchiengPaul442 changed the title [WEBSITE] change to use grids endpoint and refactored api methods [WEBSITE] changed to use grids endpoint and refactored api methods Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (57798ea) 37.58% compared to head (bd3fc67) 37.90%.
Report is 43 commits behind head on staging.

Files Patch % Lines
website/frontend/apis/index.js 54.54% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1825      +/-   ##
===========================================
+ Coverage    37.58%   37.90%   +0.31%     
===========================================
  Files           59       59              
  Lines          596      591       -5     
  Branches       115      116       +1     
===========================================
  Hits           224      224              
+ Misses         355      350       -5     
  Partials        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

New Website changes available for preview here

Copy link
Contributor

New Website changes available for preview here

@Baalmart Baalmart merged commit 4124c17 into staging Jan 23, 2024
29 checks passed
@Baalmart Baalmart deleted the Website-Design-upgrade branch January 23, 2024 19:52
@Baalmart Baalmart mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants