Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Map Implementation First Draft #1826

Merged
merged 9 commits into from
Feb 2, 2024
Merged

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Jan 23, 2024

Summary of Changes (What does this PR do?)

  • Initialized map structure as a foundation for future map functionality integration
  • Leveraged a specific library to enhance the map legend with visually appealing tooltips
  • Employed a JSON file containing country code, name, and flag image link to reduce dependency on external packages and mitigate potential security vulnerabilities
  • Improved the responsiveness of the map component, with a note for additional optimization needed for smaller mobile devices in landscape mode
  • Implemented robust error handling in key areas of map rendering to minimize potential errors during map loading

NB: Not all functionality has been implemented given this is just the first template draft for the map and more improvements shall be made.

Working functionalities

  • GPS position of the User
  • Map refresh
  • Different Map Layers
  • Zoom in and out functionality

Packages Leveraged for this implementation:

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image
imageimage
image
image

Copy link
Contributor

New next-platform changes available for preview here

Copy link
Contributor

github-actions bot commented Feb 2, 2024

New next-platform changes available for preview here

Copy link
Contributor

github-actions bot commented Feb 2, 2024

New next-platform changes available for preview here

Copy link
Contributor

github-actions bot commented Feb 2, 2024

New next-platform changes available for preview here

@OchiengPaul442 OchiengPaul442 changed the title [platform] Map skeleton [platform] Map Implementation First Draft Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

New next-platform changes available for preview here

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baalmart Baalmart merged commit eb4aeb6 into staging Feb 2, 2024
26 of 27 checks passed
@Baalmart Baalmart deleted the platform-map-template branch February 2, 2024 21:35
@Baalmart Baalmart mentioned this pull request Feb 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants