Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE] Fixed scroll bug and optimized publications code. #1834

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

OchiengPaul442
Copy link
Contributor

Summary of Changes (What does this PR do?)

  • Fixed the scrolling issue caused by the pagination on the page. This resolves a bug where the page would scroll to the top every time a new page number was generated.
  • Refactored and optimized the publication's code for better maintainability. This includes extracting common logic into helper functions and using hooks more effectively.
  • Removed the redundant 'GET INVOLVED' button from the 'About Us' dropdown menu. This simplifies the UI and reduces confusion for users.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image
image

@OchiengPaul442 OchiengPaul442 added bug Something isn't working ready for review labels Feb 1, 2024
@OchiengPaul442 OchiengPaul442 self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd3fc67) 37.90% compared to head (3d1198d) 37.90%.
Report is 52 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1834   +/-   ##
========================================
  Coverage    37.90%   37.90%           
========================================
  Files           59       59           
  Lines          591      591           
  Branches       116      116           
========================================
  Hits           224      224           
  Misses         350      350           
  Partials        17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

New Website changes available for preview here

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baalmart Baalmart merged commit 21831b6 into staging Feb 1, 2024
29 checks passed
@Baalmart Baalmart deleted the Website-Design-upgrade branch February 1, 2024 20:17
@Baalmart Baalmart mentioned this pull request Feb 1, 2024
3 tasks
@OchiengPaul442 OchiengPaul442 restored the Website-Design-upgrade branch February 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants