Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEBSITE] Implementing backend dynamic translation for french on the models #1844

Merged
merged 16 commits into from
Feb 19, 2024
Merged

[WEBSITE] Implementing backend dynamic translation for french on the models #1844

merged 16 commits into from
Feb 19, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Feb 7, 2024 •
edited
Loading

Summary of Changes (What does this PR do?)

  • Addition of translation feature to all backend models

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

rec-screen.mp4

@OchiengPaul442 OchiengPaul442 self-assigned this Feb 7, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ac8d2df) 37.90% compared to head (418d753) 38.33%.

Files Patch % Lines
website/frontend/apis/index.js 82.35% 3 Missing ⚠️
...te/frontend/reduxStore/CleanAirNetwork/CleanAir.js 25.00% 3 Missing ⚠️
...e/frontend/reduxStore/AfricanCities/CitiesSlice.js 33.33% 2 Missing ⚠️
website/frontend/reduxStore/Events/EventSlice.js 33.33% 2 Missing ⚠️
...e/frontend/reduxStore/EventsNav/NavigationSlice.js 0.00% 2 Missing ⚠️
website/frontend/reduxStore/Press/PressSlice.js 33.33% 2 Missing ⚠️
...frontend/src/components/HighlightsSection/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #1844      +/-   ##
===========================================
+ Coverage    37.90%   38.33%   +0.42%     
===========================================
  Files           59       59              
  Lines          591      587       -4     
  Branches       116      116              
===========================================
+ Hits           224      225       +1     
+ Misses         350      345       -5     
  Partials        17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@Baalmart
Copy link
Collaborator

Hi @OchiengPaul442 , please resolve the merge conflicts in this PR. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New Website changes available for preview here

Baalmart
Baalmart approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @OchiengPaul442

@Baalmart Baalmart merged commit d429515 into staging Feb 19, 2024
29 checks passed
@Baalmart Baalmart deleted the website-backend-translations branch February 19, 2024 11:13
@Baalmart Baalmart mentioned this pull request Feb 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OchiengPaul442 @Baalmart