Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Bug Fix on secondary Nav component #1906

Merged
merged 3 commits into from
Mar 13, 2024
Merged

[website] Bug Fix on secondary Nav component #1906

merged 3 commits into from
Mar 13, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Mar 13, 2024

Summary of Changes (What does this PR do?)

  • Fixed language change issue in Clean Air site's sub-navigation bar
  • Included custom LinkNames on each item.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.87%. Comparing base (53a5ff8) to head (9f4a8c4).
Report is 40 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1906   +/-   ##
========================================
  Coverage    37.87%   37.87%           
========================================
  Files           59       59           
  Lines          602      602           
  Branches       117      117           
========================================
  Hits           228      228           
  Misses         357      357           
  Partials        17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

New Website changes available for preview here

Copy link
Contributor

New Website changes available for preview here

Copy link
Contributor

New Website changes available for preview here

@Baalmart Baalmart merged commit f97191f into staging Mar 13, 2024
29 checks passed
@Baalmart Baalmart deleted the ft-cleanair branch March 13, 2024 19:54
@Baalmart Baalmart mentioned this pull request Mar 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants