Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder For Merging Email and Phone number in the profile section #1932

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

katendejericho5
Copy link
Contributor

@katendejericho5 katendejericho5 commented Mar 25, 2024

Summary of Changes (What does this PR do?)

  • Added a Reminder card For Merging Email and Phone number in the profile section appears only for users with phone number and have no platform accounts

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Screenshot_20240325-153930_AirQo

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 1.38889% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 7.73%. Comparing base (9f4a8c4) to head (cb2d222).
Report is 97 commits behind head on staging.

Files Patch % Lines
mobile/lib/screens/profile/profile_widgets.dart 2.17% 45 Missing ⚠️
mobile/lib/screens/email_link/email_link_page.dart 0.00% 11 Missing ⚠️
...ile/lib/screens/email_link/email_link_widgets.dart 0.00% 9 Missing ⚠️
mobile/lib/screens/profile/profile_view.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging   #1932       +/-   ##
===========================================
- Coverage    37.87%   7.73%   -30.14%     
===========================================
  Files           59     168      +109     
  Lines          602   12139    +11537     
  Branches       117       0      -117     
===========================================
+ Hits           228     939      +711     
- Misses         357   11200    +10843     
+ Partials        17       0       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katendejericho5 ....

  1. I hope we can have one or more of your teammates to review this PR in a timely manner.
  2. On a side note, I do hope that we have proper logging mechanisms in place to ensure that we can easily locate bugs. If we don't, then we need to prioritise them asap.

@Baalmart Baalmart merged commit 892dd6d into staging Mar 26, 2024
25 of 29 checks passed
@Baalmart Baalmart deleted the account-link-reminder branch March 26, 2024 07:58
@Baalmart Baalmart mentioned this pull request Mar 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants