Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen fix android 12 #1935

Closed
wants to merge 3 commits into from
Closed

Conversation

jordanopos
Copy link
Contributor

Summary of Changes (What does this PR do?)

  • Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Status of maturity (all need to be checked before merging):

  • [ x] I've tested this locally
  • [x ] I consider this code done
  • [ x] This change ready to hit production in its current state
  • [ x] The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.
  • Run the app locally on a device running android 12 or above. the splash screen should show normally.

What are the relevant tickets?

Screenshots (optional)

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 7.73%. Comparing base (892dd6d) to head (51eb2d0).

Files Patch % Lines
mobile/lib/themes/colors.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           staging   #1935      +/-   ##
==========================================
- Coverage     7.75%   7.73%   -0.02%     
==========================================
  Files          168     168              
  Lines        12139   12144       +5     
==========================================
- Hits           941     939       -2     
- Misses       11198   11205       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanopos jordanopos closed this Mar 27, 2024
@jordanopos jordanopos deleted the splash_screen_fix_android-12 branch March 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant