Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform] Optimize and Document Chart Component #1937

Merged
merged 6 commits into from
Mar 27, 2024
Merged

[platform] Optimize and Document Chart Component #1937

merged 6 commits into from
Mar 27, 2024

Conversation

OchiengPaul442
Copy link
Contributor

Summary of Changes (What does this PR do?)

  • Optimized rendering for both line and bar charts to improve performance.
  • Added comprehensive documentation to the component code for future reference and maintainability.
  • Adjusted the tooltip display on the bar chart to match the line chart's tooltip. This is a temporary measure until a more suitable data display approach is decided upon.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image

@OchiengPaul442 OchiengPaul442 self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Baalmart
Baalmart approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @OchiengPaul442

@Baalmart Baalmart merged commit d3482be into staging Mar 27, 2024
26 of 27 checks passed
@Baalmart Baalmart deleted the ft-charts branch March 27, 2024 10:27
@Baalmart Baalmart mentioned this pull request Mar 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

@Codebmk Codebmk Awaiting requested review from Codebmk

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OchiengPaul442 @Baalmart