Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Minor code updates to charts and customize components #1940

Merged
merged 4 commits into from
Mar 28, 2024
Merged

(chore) Minor code updates to charts and customize components #1940

merged 4 commits into from
Mar 28, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Mar 28, 2024 •
edited
Loading

Summary of Changes (What does this PR do?)

  • Optimized and used tooltips provided locally by tailwindcss hence reduced on the code written for that.
  • Disabled the tabs selector in the customize component.
  • Included strokeLines on the charts x-axis.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image
image

@OchiengPaul442 OchiengPaul442 self-assigned this Mar 28, 2024
@OchiengPaul442 OchiengPaul442 changed the title [platform] Minor code updates to charts and customize components (chore) (chore) Minor code updates to charts and customize components Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Codebmk
Codebmk approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Codebmk Codebmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@Baalmart Baalmart merged commit aa94031 into staging Mar 28, 2024
26 of 27 checks passed
@Baalmart Baalmart deleted the ft-analytics branch March 28, 2024 17:56
@Baalmart Baalmart mentioned this pull request Mar 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codebmk Codebmk Codebmk approved these changes

@Baalmart Baalmart Awaiting requested review from Baalmart

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OchiengPaul442 @Codebmk @Baalmart