Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Circular Spash Screen Error on Android 12 and above #1942

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

jordanopos
Copy link
Contributor

@jordanopos jordanopos commented Mar 29, 2024

Summary of Changes (What does this PR do?)

  • Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I've updated corresponding documentation for the changes in this PR.
  • I have written unit and/or e2e tests for my change(s).

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.75%. Comparing base (bb36219) to head (4aaef1b).
Report is 17 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging   #1942       +/-   ##
===========================================
- Coverage    37.87%   7.75%   -30.13%     
===========================================
  Files           59     168      +109     
  Lines          602   12139    +11537     
  Branches       117       0      -117     
===========================================
+ Hits           228     941      +713     
- Misses         357   11198    +10841     
+ Partials        17       0       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katendejericho5 katendejericho5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Baalmart Baalmart merged commit 13c3bf0 into staging Mar 31, 2024
26 of 29 checks passed
@Baalmart Baalmart deleted the splash-screen-fix-android-12 branch March 31, 2024 10:51
@Baalmart Baalmart mentioned this pull request Mar 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants