Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented-out navigation code from DashboardPage #2350

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Remove commented-out navigation code from DashboardPage #2350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mobile-v3/lib/src/app/dashboard/pages/dashboard_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,13 @@ class _DashboardPageState extends State<DashboardPage> {
),
SizedBox(width: 8),
GestureDetector(
onTap: () => Navigator.of(context).push(
MaterialPageRoute(
builder: (context) {
return ProfilePage();
},
),
),
// onTap: () => Navigator.of(context).push(
// MaterialPageRoute(
// builder: (context) {
// return ProfilePage();
// },
// ),
// ),
Comment on lines +100 to +106
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove commented code instead of keeping it commented out

Rather than commenting out the navigation code, it would be better to remove it entirely. Commented-out code can lead to confusion and maintenance issues over time.

Apply this diff to clean up the code:

-                // onTap: () => Navigator.of(context).push(
-                //   MaterialPageRoute(
-                //     builder: (context) {
-                //       return ProfilePage();
-                //     },
-                //   ),
-                // ),

💡 Codebase verification

Remove GestureDetector wrapper since profile navigation is disabled

The GestureDetector is still present in the code but its onTap handler is commented out, creating a misleading interactive appearance. Since the ProfilePage exists but is no longer accessible through this avatar, we should remove the GestureDetector wrapper entirely to avoid confusing users with non-functional UI elements.

  • Remove the GestureDetector wrapper in mobile-v3/lib/src/app/dashboard/pages/dashboard_page.dart and keep only the CircleAvatar widget
  • If profile access is intended to be temporarily disabled, create a tracking issue to implement the new navigation pattern
🔗 Analysis chain

Consider UX implications of removing profile navigation

The profile avatar still appears clickable (it's wrapped in a GestureDetector) but no longer responds to taps. This might confuse users who expect interaction. Consider either:

  1. Removing the GestureDetector entirely if profile navigation is permanently disabled
  2. Adding a tooltip or visual indication that this is non-interactive
  3. Implementing an alternative navigation method if profile access is still needed

Let's verify if profile navigation exists elsewhere in the app:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for ProfilePage navigation patterns in the codebase
rg -l "MaterialPageRoute.*ProfilePage" --type dart

Length of output: 52

Script:

#!/bin/bash
# Let's try a broader search for ProfilePage usage and navigation patterns
rg -i "profilepage" --type dart -A 3

# Also search for any route definitions related to profile
rg -i "profile.*route" --type dart -A 3

# Search for GestureDetector wrapping profile-related widgets
ast-grep --pattern 'GestureDetector(
  $$$
  child: CircleAvatar($$$)
  $$$
)'

# Look for any profile-related navigation in the codebase
rg "navigator.*profile" --type dart -i -A 3

Length of output: 1454

Script:

#!/bin/bash
# Let's check if the GestureDetector is still present in the current code
rg "GestureDetector" mobile-v3/lib/src/app/dashboard/pages/dashboard_page.dart -A 5 -B 5

# Check if there are any other ways to access the profile
rg "ProfilePage" mobile-v3/lib/src/app/profile/pages/profile_page.dart -A 10

# Look for any navigation methods in the app
ast-grep --pattern 'onTap: () => Navigator.of($$$)'

Length of output: 2258

child: BlocBuilder<UserBloc, UserState>(
builder: (context, state) {
if (state is UserLoaded) {
Expand Down
Loading