Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Updated image Layout for data-access section (research page) #2384

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Jan 16, 2025

Summary of Changes (What does this PR do?)

  • image Layout change

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image

Summary by CodeRabbit

  • UI/UX Improvements

    • Refined layout of the Data Access section with improved grid system
    • Increased section width and adjusted padding
    • Enhanced spacing between content elements
    • Simplified image display logic
    • Updated blob overlay positioning and styling
  • Content Updates

    • Reduced number of consultation images displayed

Copy link

coderabbitai bot commented Jan 16, 2025

Warning

Rate limit exceeded

@OchiengPaul442 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a5f627a and cce536b.

📒 Files selected for processing (1)
  • website2/src/views/solutions/research/data-access.tsx (3 hunks)
📝 Walkthrough

Walkthrough

The pull request modifies the data-access.tsx file in the website's solutions research section, focusing on refining the visual layout and image presentation of the DataAccessSection component. The changes involve transitioning from a flexbox to a grid layout, adjusting spacing and maximum width, simplifying image display logic, and reducing the number of displayed consultation images.

Changes

File Change Summary
website2/src/views/solutions/research/data-access.tsx - Increased max-width from max-w-5xl to max-w-7xl
- Switched layout from flexbox to grid
- Reduced consultation images
- Updated image display and blob overlay styling

Possibly related PRs

Suggested reviewers

  • Baalmart
  • Codebmk

Poem

🌐 Pixels dance, layout rearranged
Grid replaces flex, images exchanged
Blobs and images, a digital art
Research view gets a stylish restart! 🎨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
website2/src/views/solutions/research/data-access.tsx (2)

100-106: Optimize image loading performance.

While the image implementation works, consider these performance improvements:

  1. Add blurDataURL and placeholder="blur" for better loading experience
  2. Define sizes prop to help with resource prioritization
  3. Add error handling for invalid image URLs
 <Image
   src={CONTENT.images.consultation[0] || '/placeholder.svg'}
   alt="Air Quality Monitoring Equipment"
   fill
   className="object-cover hover:scale-105 transition-transform duration-300"
   priority
+  sizes="(max-width: 768px) 100vw, 50vw"
+  placeholder="blur"
+  blurDataURL="data:image/jpeg;base64,/9j/4AAQSkZJRg..."
+  onError={(e) => {
+    e.currentTarget.src = '/placeholder.svg'
+  }}
 />

109-119: Consider responsive adjustments for the blob overlay.

The blob overlay looks good, but consider these improvements:

  1. Add responsive sizing for smaller screens
  2. Since this is a decorative element, add loading="lazy" and remove priority
 <Image
   src={CONTENT.images.blob || '/placeholder.svg'}
   alt="Blob Overlay"
   fill
   className="object-contain opacity-50"
+  loading="lazy"
+  className="object-contain opacity-50 lg:w-[120%] lg:h-[120%] w-[100%] h-[100%]"
 />
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd14846 and a5f627a.

📒 Files selected for processing (1)
  • website2/src/views/solutions/research/data-access.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-push-website2-deploy-preview
🔇 Additional comments (3)
website2/src/views/solutions/research/data-access.tsx (3)

41-41: Layout structure improvements look solid! 👍

The transition from flexbox to grid layout (grid lg:grid-cols-2) and the increased max-width (max-w-7xl) create a more robust and spacious layout. The grid system is particularly well-suited for this two-column responsive design.

Also applies to: 43-43


50-50: Typography and spacing refinements enhance readability.

Good improvements in the content structure:

  • Increased spacing (space-y-6) improves content breathing room
  • Responsive heading size with proper scaling
  • Accessible link styling with clear hover states

Also applies to: 52-52, 68-68


Line range hint 41-124: Verify external resources and animation performance.

Let's ensure all external resources are accessible and animations perform well:

  1. Verify Cloudinary image URLs
  2. Check animation performance on lower-end devices
✅ Verification successful

External resources and animations verified successfully

All external resources are accessible and properly configured. The animation implementation follows performance best practices with appropriate viewport optimization and transform animations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the Cloudinary URLs are accessible
curl -I "https://res.cloudinary.com/dbibjvyhm/image/upload/v1728248677/website/photos/Solutions/AirQo_blob_fill_ro37jv.svg"
curl -I "https://res.cloudinary.com/dbibjvyhm/image/upload/v1737011992/website/photos/Solutions/6T9B9239_ksveld.jpg"

# Check if the UN document URL is accessible
curl -I "https://documents-dds-ny.un.org/doc/UNDOC/GEN/K18/002/22/PDF/K1800222.pdf"

Length of output: 3425

Copy link
Contributor

New Website2 changes available for preview here

1 similar comment
Copy link
Contributor

New Website2 changes available for preview here

@Baalmart Baalmart merged commit 9d4fecc into staging Jan 16, 2025
31 checks passed
@Baalmart Baalmart deleted the website-research-implemnt branch January 16, 2025 12:14
@Baalmart Baalmart mentioned this pull request Jan 16, 2025
5 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 16, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants