Website clean air Forum Updates #2467

OchiengPaul442 · 2025-02-14T02:38:16Z

Summary of Changes (What does this PR do?)

Fixed the styling issue on html insert sections

Status of maturity (all need to be checked before merging):

I've tested this locally
I consider this code done
This change ready to hit production in its current state

Screenshots (optional)

Summary by CodeRabbit

New Dependencies
- Integrated a new Tailwind CSS typography utility to enhance text styling.
Style
- Updated layouts and visual elements across various pages for improved readability.
- Adjusted spacing, padding, and text formatting by replacing some flex-based structures with a unified prose style.
- Added visual dividers to better separate content sections.
Refactor
- Streamlined component structures and styling for a more consistent and engaging user experience.

coderabbitai · 2025-02-14T02:38:23Z

📝 Walkthrough

Walkthrough

This pull request introduces styling and configuration updates across multiple parts of the project. The package.json and Tailwind configuration now include the typography plugin, enabling enhanced text styling. Several page components across the clean-air-forum, Forum views, and event pages have updated container and child element class names, moving toward a consistent "prose max-w-none" layout alongside adjusted padding and spacing. The MemberCard component also received client-rendering hints and layout refinements. These modifications solely affect presentation without altering core functionality.

Changes

File(s)	Change Summary
`website2/package.json`, `website2/tailwind.config.ts`	Added `@tailwindcss/typography` dependency in package.json and integrated the typography plugin in Tailwind config.
`website2/src/app/clean-air-forum/{glossary, logistics, partners, program-committee, resources, sessions, speakers, sponsorships}/page.tsx`	Updated container and child element class names to adopt a consistent "prose max-w-none" layout; added/remodeled padding and Divider components to enhance spacing and structure.
`website2/src/views/Forum/{AboutPage, SectionDisplay, TabNavigation}.tsx`	Refined layout styling: added Divider components in AboutPage, streamlined content rendering in SectionDisplay, and replaced underline with no-underline in TabNavigation links.
`website2/src/views/cleanairforum/{PaginatedSection.tsx, events/SingleEvent.tsx}`, `website2/src/views/events/SingleEvent.tsx`	Adjusted class names in event pages and paginated sections to improve responsiveness and remove fixed sizing constraints.
`website2/src/components/ui/MemberCard.tsx`	Introduced the `'use client';` directive, updated the default button text to "Read Bio", and restructured layout elements for enhanced visual presentation.

Suggested reviewers

Baalmart
Codebmk

Poem

In the realm of code where styles align,
A sprinkle of prose makes every page shine.
New plugins and classes join the show,
Refining layouts with a designer’s glow.
With each commit, fresh vibes arise—
A visual symphony before our eyes!
🚀✨

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (6)

website2/src/views/cleanairforum/PaginatedSection.tsx (1)
67-67: Consider using responsive width for better mobile experience.

While the current styling works well, consider making the min-width responsive:
-className="object-contain w-full h-full max-h-[144px] min-w-[271px] p-3 max-w-[271px] mix-blend-multiply transition-transform duration-500 ease-in-out transform hover:scale-110"
+className="object-contain w-full h-full max-h-[144px] min-w-[200px] sm:min-w-[271px] p-3 max-w-[271px] mix-blend-multiply transition-transform duration-500 ease-in-out transform hover:scale-110"
website2/src/app/clean-air-forum/logistics/page.tsx (1)
50-52: Consider extracting HTML rendering logic into a reusable component.

Multiple instances of dangerouslySetInnerHTML with DOMPurify could be consolidated into a shared component for better maintainability and consistency.
+// components/SafeHTML.tsx
+import DOMPurify from 'dompurify';
+
+interface SafeHTMLProps {
+  content: string;
+  className?: string;
+}
+
+export const SafeHTML: React.FC<SafeHTMLProps> = ({ content, className }) => (
+  <div
+    className={className}
+    dangerouslySetInnerHTML={{
+      __html: DOMPurify.sanitize(content),
+    }}
+  />
+);
Also applies to: 72-74

🧰 Tools

🪛 Biome (1.9.4)

[error] 50-50: Avoid passing content using the dangerouslySetInnerHTML prop.

Setting content using code can expose users to cross-site scripting (XSS) attacks

(lint/security/noDangerouslySetInnerHtml)
website2/src/app/clean-air-forum/program-committee/page.tsx (1)
19-24: Consider adding type safety for person category filtering.

Using string literals for category filtering could lead to maintenance issues.
+type PersonCategory = 'Committee Member' | 'Committee Member and Key Note Speaker' | 'Speaker and Committee Member';
+
+interface Person {
+  id: string;
+  category: PersonCategory;
+  // ... other properties
+}
+
 const committeeMembers = useMemo(
   () =>
-    data?.persons?.filter(
-      (person: any) =>
+    data?.persons?.filter((person: Person) =>
         person.category === 'Committee Member' ||
         person.category === 'Committee Member and Key Note Speaker' ||
         person.category === 'Speaker and Committee Member',
     ) || [],
   [data?.persons],
 );
website2/src/app/clean-air-forum/glossary/page.tsx (1)
56-69: Enhance accessibility for external links.

Links opening in new tabs should indicate this behavior to users.
 <Link
   href={href}
   target="_blank"
+  rel="noopener noreferrer"
   onClick={(e) => {
     e.preventDefault();
     window.open(href, '_blank');
   }}
   className={`text-blue-600 hover:underline ${
     selectedEventIndex === index ? 'font-bold' : ''
   }`}
+  aria-label={`Open ${event.title} in new tab`}
 >
   {event.title}
 </Link>
website2/src/app/clean-air-forum/resources/page.tsx (1)
114-114: Consider adding responsive padding for better mobile experience.

While the prose class enhances typography, consider adding responsive padding classes for improved mobile readability.
-    <div className="px-4 prose max-w-none lg:px-0">
+    <div className="px-4 md:px-6 prose max-w-none lg:px-8">
website2/src/components/ui/MemberCard.tsx (1)
62-70: Enhance image loading with priority prop.

Consider adding the priority prop for above-the-fold images to improve LCP (Largest Contentful Paint).
 <Image
   src={member.picture_url || member.picture || PlaceholderImage}
   alt={member.name}
   fill
   sizes="(max-width: 640px) 100vw, 300px"
+  priority={true}
   className="object-cover transition-transform duration-300 ease-in-out hover:scale-105"
 />

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e08c96b and 3af280c.

⛔ Files ignored due to path filters (1)

website2/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (17)

website2/package.json (1 hunks)
website2/src/app/clean-air-forum/glossary/page.tsx (3 hunks)
website2/src/app/clean-air-forum/logistics/page.tsx (2 hunks)
website2/src/app/clean-air-forum/partners/page.tsx (1 hunks)
website2/src/app/clean-air-forum/program-committee/page.tsx (1 hunks)
website2/src/app/clean-air-forum/resources/page.tsx (2 hunks)
website2/src/app/clean-air-forum/sessions/page.tsx (2 hunks)
website2/src/app/clean-air-forum/speakers/page.tsx (1 hunks)
website2/src/app/clean-air-forum/sponsorships/page.tsx (1 hunks)
website2/src/components/ui/MemberCard.tsx (5 hunks)
website2/src/views/Forum/AboutPage.tsx (4 hunks)
website2/src/views/Forum/SectionDisplay.tsx (1 hunks)
website2/src/views/Forum/TabNavigation.tsx (1 hunks)
website2/src/views/cleanairforum/PaginatedSection.tsx (1 hunks)
website2/src/views/cleanairforum/events/SingleEvent.tsx (1 hunks)
website2/src/views/events/SingleEvent.tsx (1 hunks)
website2/tailwind.config.ts (1 hunks)

✅ Files skipped from review due to trivial changes (4)

website2/src/views/events/SingleEvent.tsx
website2/src/views/Forum/TabNavigation.tsx
website2/src/app/clean-air-forum/speakers/page.tsx
website2/src/views/cleanairforum/events/SingleEvent.tsx

🧰 Additional context used

🪛 Biome (1.9.4)

website2/src/views/Forum/SectionDisplay.tsx

[error] 33-33: Avoid passing content using the dangerouslySetInnerHTML prop.