Move frontend Apps to src Folder #2487
Conversation
📝 WalkthroughWalkthroughThis pull request updates various configuration and workflow files to reflect a revised directory structure. Most changes involve updating file and working directory paths from locations such as Changes
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New Docs changes available for preview here |
|
New inventory changes available for preview here |
|
New calibrate app changes available for preview here |
|
New next-platform changes available for preview here |
|
New reports changes available for preview here |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
.github/workflows/remove-deploy-previews.yml (1)
78-79: Remove Trailing Spaces
Static analysis indicates that there are trailing spaces on these lines. Removing them will help ensure consistent YAML formatting.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 78-78: trailing spaces
(trailing-spaces)
[error] 79-79: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-production.yml (1)
225-225: Address Static Analysis Warnings
YAML lint has flagged trailing spaces at lines 225 and 554 and a missing newline at the end of the file (line 613). Please remove the extra spaces and add a newline at the end to conform to best practices for YAML files.Also applies to: 554-554, 613-613
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 225-225: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-staging.yml (2)
143-143: Consider Upgrading the Setup-Node Action
Static analysis suggests that the runner foractions/setup-node@v3is outdated. Upgrading to a newer version could enhance reliability and performance on GitHub Actions.Also applies to: 407-407
🧰 Tools
🪛 actionlint (1.7.4)
143-143: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
86-90: Remove Trailing Spaces
There are trailing spaces on the indicated lines. Removing these will help clear YAML lint warnings and maintain consistency in file formatting.Also applies to: 140-140
.github/workflows/deploy-frontend-pr-previews.yml (2)
122-122: Upgrade Setup-Node Action
Static analysis indicates that the runner foractions/setup-node@v2is outdated. It is recommended to update to a newer version to avoid any potential issues during the build and deployment steps.Also applies to: 209-209
🧰 Tools
🪛 actionlint (1.7.4)
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
86-90: Remove Trailing Spaces
Please remove the extra trailing spaces on these lines to resolve YAML lint warnings and improve overall file cleanliness.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (70)
mobile-v3/android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarmobile/android/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarsrc/Maintenance/www/imgs/Logo.svgis excluded by!**/*.svgsrc/Maintenance/www/imgs/Oops.svgis excluded by!**/*.svgsrc/calibrate/package-lock.jsonis excluded by!**/package-lock.jsonsrc/calibrate/public/favicon-16x16.pngis excluded by!**/*.pngsrc/calibrate/public/favicon-32x32.pngis excluded by!**/*.pngsrc/calibrate/public/favicon-96x96.pngis excluded by!**/*.pngsrc/calibrate/public/favicon.icois excluded by!**/*.icosrc/calibrate/public/logo192.pngis excluded by!**/*.pngsrc/calibrate/public/logo512.pngis excluded by!**/*.pngsrc/calibrate/src/logo.svgis excluded by!**/*.svgsrc/docs/_media/airqalibrate_1.pngis excluded by!**/*.pngsrc/docs/_media/airqalibrate_2.pngis excluded by!**/*.pngsrc/docs/_media/airqalibrate_3.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_1.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_2.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_3.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_4.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_5.pngis excluded by!**/*.pngsrc/docs/_media/analytics_customisable_charts_6.pngis excluded by!**/*.pngsrc/docs/_media/analytics_download_data.pngis excluded by!**/*.pngsrc/docs/_media/analytics_exceedances.pngis excluded by!**/*.pngsrc/docs/_media/analytics_mean_daily_pm.pngis excluded by!**/*.pngsrc/docs/_media/analytics_region_status_cards.pngis excluded by!**/*.pngsrc/docs/_media/analytics_select_location_1.pngis excluded by!**/*.pngsrc/docs/_media/analytics_select_location_2.pngis excluded by!**/*.pngsrc/docs/_media/extras_account_settings.pngis excluded by!**/*.pngsrc/docs/_media/extras_add_user.pngis excluded by!**/*.pngsrc/docs/_media/extras_feedback_1.pngis excluded by!**/*.pngsrc/docs/_media/extras_feedback_2.pngis excluded by!**/*.pngsrc/docs/_media/extras_feedback_3.pngis excluded by!**/*.pngsrc/docs/_media/extras_feedback_4.pngis excluded by!**/*.pngsrc/docs/_media/extras_settings.pngis excluded by!**/*.pngsrc/docs/_media/favicon.pngis excluded by!**/*.pngsrc/docs/_media/join_forgot_password.pngis excluded by!**/*.pngsrc/docs/_media/join_request_access.pngis excluded by!**/*.pngsrc/docs/_media/logo.pngis excluded by!**/*.pngsrc/docs/_media/ml_based_approach_bam_1.pngis excluded by!**/*.pngsrc/docs/_media/ml_based_approach_bam_2.pngis excluded by!**/*.pngsrc/docs/_media/ml_based_approach_bam_3.pngis excluded by!**/*.pngsrc/docs/_media/monitor_1.pngis excluded by!**/*.pngsrc/docs/_media/monitor_2.pngis excluded by!**/*.pngsrc/docs/_media/monitor_3.pngis excluded by!**/*.pngsrc/docs/_media/monitor_4.pngis excluded by!**/*.pngsrc/docs/package-lock.jsonis excluded by!**/package-lock.jsonsrc/docs/yarn.lockis excluded by!**/yarn.lock,!**/*.locksrc/inventory/assets/admin/img/calendar-icons.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/gis/move_vertex_off.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/gis/move_vertex_on.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-addlink.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-alert.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-calendar.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-changelink.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-clock.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-deletelink.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-no.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-unknown-alt.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-unknown.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-viewlink.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/icon-yes.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/inline-delete.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/search.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/selector-icons.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/sorting-icons.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/tooltag-add.svgis excluded by!**/*.svgsrc/inventory/assets/admin/img/tooltag-arrowright.svgis excluded by!**/*.svgsrc/inventory/assets/admin/js/vendor/jquery/jquery.min.jsis excluded by!**/*.min.jssrc/inventory/assets/admin/js/vendor/select2/select2.full.min.jsis excluded by!**/*.min.jssrc/inventory/assets/admin/js/vendor/xregexp/xregexp.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (26)
.github/dependabot.yml(1 hunks).github/workflows/dart-code-metrics.yaml(3 hunks).github/workflows/deploy-android-to-firebase-app-distribution.yml(2 hunks).github/workflows/deploy-android-to-play-store.yml(2 hunks).github/workflows/deploy-frontend-pr-previews.yml(18 hunks).github/workflows/deploy-frontends-to-production.yml(22 hunks).github/workflows/deploy-frontends-to-staging.yml(23 hunks).github/workflows/mobile-app-tests.yaml(3 hunks).github/workflows/netmanager-tests.yml(2 hunks).github/workflows/remove-deploy-previews.yml(1 hunks).github/workflows/test-changes.yml(5 hunks).github/workflows/website-tests-changes.yml(2 hunks)k8s/platform/values-prod.yaml(1 hunks)k8s/platform/values-stage.yaml(1 hunks)mobile-v3/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java(0 hunks)mobile-v3/android/gradlew(0 hunks)mobile-v3/android/gradlew.bat(0 hunks)mobile-v3/ios/Flutter/Generated.xcconfig(0 hunks)mobile-v3/ios/Flutter/flutter_export_environment.sh(0 hunks)mobile-v3/ios/Runner/GeneratedPluginRegistrant.h(0 hunks)mobile-v3/ios/Runner/GeneratedPluginRegistrant.m(0 hunks)mobile/android/gradlew(0 hunks)mobile/android/gradlew.bat(0 hunks)platform/.vscode/extensions.json(0 hunks)platform/.vscode/launch.json(0 hunks)platform/.vscode/settings.json(0 hunks)
💤 Files with no reviewable changes (12)
- platform/.vscode/extensions.json
- platform/.vscode/launch.json
- mobile-v3/ios/Runner/GeneratedPluginRegistrant.h
- mobile-v3/ios/Flutter/Generated.xcconfig
- mobile-v3/ios/Runner/GeneratedPluginRegistrant.m
- platform/.vscode/settings.json
- mobile-v3/android/gradlew
- mobile-v3/ios/Flutter/flutter_export_environment.sh
- mobile/android/gradlew
- mobile-v3/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
- mobile/android/gradlew.bat
- mobile-v3/android/gradlew.bat
✅ Files skipped from review due to trivial changes (2)
- .github/dependabot.yml
- .github/workflows/deploy-android-to-play-store.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/deploy-frontend-pr-previews.yml
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-staging.yml
[error] 85-85: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 665-665: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/remove-deploy-previews.yml
[error] 78-78: trailing spaces
(trailing-spaces)
[error] 79-79: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-production.yml
[error] 225-225: trailing spaces
(trailing-spaces)
[error] 554-554: trailing spaces
(trailing-spaces)
[error] 613-613: no new line character at the end of file
(new-line-at-end-of-file)
[error] 613-613: trailing spaces
(trailing-spaces)
🪛 actionlint (1.7.4)
.github/workflows/deploy-frontend-pr-previews.yml
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
209-209: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/deploy-frontends-to-staging.yml
143-143: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
407-407: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/deploy-frontends-to-production.yml
85-85: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
355-355: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build-push-website2-deploy-preview
- GitHub Check: build-push-deploy-netmanager-preview
- GitHub Check: netmanager code tests
🔇 Additional comments (25)
k8s/platform/values-prod.yaml (1)
31-31: Ensure YAML Hierarchy and Template IntegrationThe addition of
priorityClassName: high-priorityat line 31 is clear and well-formatted. Please ensure that this new configuration key is referenced properly in your Helm deployment templates so that pods are scheduled with the intended high priority.k8s/platform/values-stage.yaml (1)
27-27: Maintain Consistency Across EnvironmentsThe newly added
priorityClassName: high-priorityparameter on line 27 is consistent with the production configuration. Just double-check that your staging deployment templates are updated accordingly to utilize this parameter and achieve the desired pod scheduling behavior..github/workflows/netmanager-tests.yml (2)
37-39: Path Check Update:
The condition now correctly checks for files matchingsrc/netmanager/*, which aligns with the updated directory structure.
50-50: Working Directory Update:
Theworking-directoryhas been updated tosrc/netmanager, ensuring that the job executes in the correct folder..github/workflows/mobile-app-tests.yaml (2)
37-39: Path Check Update:
The conditional check for modified files now usessrc/mobile/*as the pattern, which is consistent with the new folder organization.
50-50: Working Directory Update:
Theworking-directoryin the defaults section has been updated tosrc/mobile, reflecting the restructuring accurately..github/workflows/dart-code-metrics.yaml (3)
32-33: Path Check Update:
The modified file check now targetssrc/mobile/*—this update is correct and ensures that code metrics are applied to the intended directory.
50-50: Relative Path Update:
Therelative_pathparameter has been updated tosrc/mobile/, which is appropriate given the new location of the mobile app code.
64-64: Working Directory Update:
The working directory for the App code analysis job is now set tosrc/mobile, aligning with the overall project reorganization..github/workflows/deploy-android-to-firebase-app-distribution.yml (2)
18-18: Job Working Directory Update:
The defaultworking-directoryhas been updated frommobiletosrc/mobile, which is correct following the directory reorganization.
73-73: Fastlane Directory Update:
Theworking-directoryfor the Setup Fastlane step has been updated tosrc/mobile/android, ensuring the step runs in the appropriate context..github/workflows/test-changes.yml (7)
35-38: Analytics Platform File Check:
The check now inspects files matchingsrc/platform/*to determine if analytics platform tests should run, which is consistent with the new structure.
39-41: Docs File Check:
The condition correctly identifies modifications in the docs folder by checking for files undersrc/docs/*.
66-67: .env File Path Update:
The commands now retrieve and write the environment file tosrc/platform/.envand append theINSTRUMENT_CODEvariable correctly.
71-73: Cypress Working Directory Update (Analytics Platform):
The working directory for the Cypress run is now set to./src/platform/, ensuring that the correct files are used during testing.
86-87: Codecov Directory Update (Analytics Platform):
The directory for uploading coverage reports has been updated tosrc/platform/coverage/, which reflects the new file organization accurately.
103-104: Cypress Working Directory Update (Docs):
The working directory for the Cypress run in the docs job is now updated to./src/docs/, aligning with the new directory structure.
116-117: Docs Coverage Directory Update:
The directory for deploying the docs code coverage report is now correctly set to./src/docs/coverage/lcov-report..github/workflows/website-tests-changes.yml (2)
37-38: Updated File Check Condition
The condition now correctly checks for files in thesrc/website/directory instead of the oldwebsite/path. This ensures that website tests are triggered only when files under the new directory structure change.
70-70: Updated Credentials Directory
The directory for creating thegoogle_application_credentials.jsonfile has been updated tosrc/website/, which aligns with the new project structure. Please verify if theworking-directorysetting in subsequent steps should also be updated for full consistency..github/workflows/remove-deploy-previews.yml (1)
60-80: Updated Deployment Preview Path Checks
The file path conditions for checking modified files have been revised to use thesrc/prefix (for netmanager, calibrate, platform, docs, inventory, and reports). This change properly reflects the new folder organization and ensures that deploy previews are managed based on updates in the correct directories.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 78-78: trailing spaces
(trailing-spaces)
[error] 79-79: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-production.yml (2)
82-89: Updated Netmanager Deployment Paths
The command to create the.envfile and the subsequent navigation (usingcd src/netmanager/) have been updated to reflect the new directory structure. This change is consistent and should ensure that the netmanager image is built from the correct source folder.🧰 Tools
🪛 actionlint (1.7.4)
85-85: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
161-169: Updated Website Credentials and Environment Configuration
The step for creating thegoogle_application_credentials.jsonfile now referencessrc/website/, and the app configuration steps have been updated accordingly. Please double-check that all subsequent commands correctly use the new folder structure..github/workflows/deploy-frontends-to-staging.yml (1)
74-106: Updated Frontend Deployment Path Checks
All checks for modified files now point to the appropriatesrc/directories, including netmanager, website, website2, calibrate, analytics platform, docs, inventory, and reports. This update ensures that staging deployments are triggered only when the correct files are modified.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 85-85: trailing spaces
(trailing-spaces)
[error] 101-101: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontend-pr-previews.yml (1)
530-531: Updated Preview Deployment Paths
The directory references throughout the workflow have been updated to include thesrc/prefix. This ensures that the preview deployments accurately reflect the new file structure and that all build and push commands use the correct source directories.
|
New netmanager changes available for preview here |
|
New Docs changes available for preview here |
|
New inventory changes available for preview here |
|
New calibrate app changes available for preview here |
|
New next-platform changes available for preview here |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (6)
.github/workflows/deploy-frontend-pr-previews.yml (3)
122-122: Upgrade Node Setup Action Version
The workflow usesactions/setup-node@v2, which has been flagged as outdated. Consider upgrading toactions/setup-node@v3to benefit from improvements and ensure compatibility with GitHub Actions.🧰 Tools
🪛 actionlint (1.7.4)
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
86-86: Remove Trailing Spaces
Trailing spaces have been detected on this line. Removing them will help keep the YAML file clean and compliant with linting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 86-86: trailing spaces
(trailing-spaces)
90-90: Remove Trailing Spaces
There are trailing spaces on this line as well; please remove them to avoid potential YAML formatting issues.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 90-90: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-production.yml (3)
225-225: Remove Trailing Spaces
Trailing spaces were detected on this line. Please remove them to comply with YAML formatting standards.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 225-225: trailing spaces
(trailing-spaces)
579-579: Remove Trailing Spaces
There are extra spaces at the end of this line. Cleaning them up will help avoid linting issues.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 579-579: trailing spaces
(trailing-spaces)
638-638: Ensure a Trailing Newline at the End of the File
The file is missing a newline at the end—which is a best practice for text files. Please add one.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 638-638: no new line character at the end of file
(new-line-at-end-of-file)
[error] 638-638: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/deploy-frontend-pr-previews.yml(18 hunks).github/workflows/deploy-frontends-to-production.yml(22 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/deploy-frontend-pr-previews.yml
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
.github/workflows/deploy-frontends-to-production.yml
[error] 225-225: trailing spaces
(trailing-spaces)
[error] 579-579: trailing spaces
(trailing-spaces)
[error] 638-638: no new line character at the end of file
(new-line-at-end-of-file)
[error] 638-638: trailing spaces
(trailing-spaces)
🪛 actionlint (1.7.4)
.github/workflows/deploy-frontend-pr-previews.yml
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
209-209: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/deploy-frontends-to-production.yml
85-85: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
380-380: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-push-website2-deploy-preview
- GitHub Check: build-push-deploy-reports-preview
- GitHub Check: build-push-deploy-netmanager-preview
- GitHub Check: build-push-deploy-calibrate-app-preview
- GitHub Check: build-push-deploy-analytics-platform-preview
- GitHub Check: netmanager code tests
🔇 Additional comments (20)
.github/workflows/deploy-frontend-pr-previews.yml (11)
61-94: Update File Path Checks to Reflect the Newsrc/Structure
The conditional blocks that check modified file paths have been updated (e.g.,if [[ $file == src/netmanager/* ]]; then) to correctly identify changes under the newsrc/directory. This ensures that the appropriate deploy jobs are triggered based on the new layout.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
118-120: Update .env File Path for Netmanager Preview
The command now directs the secret output tosrc/netmanager/.env, which aligns with the restructured folder paths. Verify that the secret name ("sta-env-netmanager") is still valid in this context.
126-129: Align Netmanager Build Step with New Directory Structure
Changing directory tosrc/netmanager/for the npm install and build step ensures that the source code is correctly targeted. This change appears consistent with the project reorganization.
139-144: Update Docker Build Commands for Netmanager
The Docker image build and push commands now use the updated directory (cd src/netmanager/), ensuring that the proper Dockerfile and assets are used.
205-213: Update Calibrate App Job Paths
The.envcreation and build commands have been updated to usesrc/calibrate/. This change correctly reflects the new folder structure for the calibrate app.🧰 Tools
🪛 actionlint (1.7.4)
209-209: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
292-304: Update Analytics Platform Paths
The environment file is now created insrc/platform/.envand the build step switches tosrc/platform/. This update maintains consistency with the new directory layout.🧰 Tools
🪛 actionlint (1.7.4)
296-296: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
368-380: Update Inventory Job Paths
Both the creation of the.envfile and the Docker build commands have been modified to usesrc/inventory/. This update is essential to ensure that the inventory service is built from the correct location.🧰 Tools
🪛 actionlint (1.7.4)
372-372: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
453-458: Update Docs Build Directory Path
The docker build step now changes intosrc/docs/rather than a root-level folder, which matches the reorganized project structure.
528-536: Update Website Deployment Paths
The job now creates the credentials file insrc/website/and changes to that directory before beginning the build process. This correctly reflects the folder reorganization.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 535-535: trailing spaces
(trailing-spaces)
642-650: Update Website2 Deployment Paths
The changes ensure that the Google application credentials and the build steps now referencesrc/website2/. This helps maintain a consistent directory structure across all frontend apps.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 649-649: trailing spaces
(trailing-spaces)
732-744: Update Reports Deployment Paths
The commands to create the.envfile and build the Docker image now point tosrc/reports/, aligning with the overall restructuring initiative.🧰 Tools
🪛 actionlint (1.7.4)
736-736: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/deploy-frontends-to-production.yml (9)
81-83: Update .env File Path for Netmanager Production
The command now directs the creation of the.envfile tosrc/netmanager/.env, which is in line with the new directory structure. This change should help avoid path mismatches during deployment.
88-107: Align Netmanager Build Steps with Restructured Paths
The build steps for the netmanager job now change directory tosrc/netmanager/before executing Docker build commands. This update confirms that the job will target the correct source files post-reorganization.🧰 Tools
🪛 actionlint (1.7.4)
94-94: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
160-170: Update Website Deployment Paths
The job now creates credentials insrc/website/(as seen in the updateddirparameter) and proceeds to build from that directory. This is a critical change to ensure the website service is built using the reorganized source files.
264-272: Update Website2 Deployment Paths
By setting the directory parameter tosrc/website2/for the credentials file and switching directories for the build step, the workflow now correctly adheres to the new file layout.
376-384: Update Calibrate App Production Job Paths
The calibrate app job now creates the.envfile insrc/calibrate/and navigates to that directory prior to building. This modification is consistent with the overall restructuring.🧰 Tools
🪛 actionlint (1.7.4)
380-380: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
444-460: Update Analytics Platform Production Paths
The production job for analytics platform now writes the environment file tosrc/platform/.envand changes into that folder for the build step. This ensures the deployment uses the correct source files.🧰 Tools
🪛 actionlint (1.7.4)
448-448: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
502-509: Update Docs Build Path for Production
The docs service build now uses thesrc/docs/directory, which correctly reflects the new project organization and should help avoid path-related errors during the build.
540-558: Update Inventory Job Paths for Production
The inventory job now creates its.envfile insrc/inventory/and changes directory accordingly before running Docker build steps, ensuring consistency with the new structure.🧰 Tools
🪛 actionlint (1.7.4)
544-544: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
599-616: Update Reports Job Paths for Production
The reports service now accesses its environment file fromsrc/reports/and performs the build from within that directory. This update aligns with the directory reorganization objectives.🧰 Tools
🪛 actionlint (1.7.4)
603-603: the runner of "docker/login-action@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
|
New reports changes available for preview here |
|
New netmanager changes available for preview here |
|
New Website changes available for preview here |
|
New Docs changes available for preview here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #2487 +/- ##
=============================================
+ Coverage 7.79% 100.00% +92.20%
=============================================
Files 166 1 -165
Lines 11973 5 -11968
Branches 0 2 +2
=============================================
- Hits 933 5 -928
+ Misses 11040 0 -11040 ☔ View full report in Codecov by Sentry. |
|
New inventory changes available for preview here |
|
New calibrate app changes available for preview here |
|
New next-platform changes available for preview here |
|
New reports changes available for preview here |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/deploy-frontend-pr-previews.yml (4)
86-86: Remove Trailing Whitespace
Trailing whitespace detected on this line. Please remove extra spaces at the end of the line.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 86-86: trailing spaces
(trailing-spaces)
90-90: Remove Trailing Whitespace
Trailing whitespace detected on this line. Please remove the extra spaces.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 90-90: trailing spaces
(trailing-spaces)
121-125: Upgrade Node.js Setup Action
The workflow usesactions/setup-node@v2, which is now considered outdated. It is recommended to update this action toactions/setup-node@v3for improved performance and security.- uses: actions/setup-node@v2 + uses: actions/setup-node@v3🧰 Tools
🪛 actionlint (1.7.4)
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
208-211: Upgrade Calibrate App Node Setup Action
The calibrate workflow also usesactions/setup-node@v2. Please consider updating it toactions/setup-node@v3to stay current with best practices.- uses: actions/setup-node@v2 + uses: actions/setup-node@v3🧰 Tools
🪛 actionlint (1.7.4)
209-209: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/deploy-frontend-pr-previews.yml(17 hunks).github/workflows/website-tests-changes.yml(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/website-tests-changes.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/deploy-frontend-pr-previews.yml
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
🪛 actionlint (1.7.4)
.github/workflows/deploy-frontend-pr-previews.yml
122-122: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
209-209: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build-push-website2-deploy-preview
- GitHub Check: build-push-deploy-reports-preview
- GitHub Check: build-push-deploy-netmanager-preview
- GitHub Check: netmanager code tests
- GitHub Check: build-push-deploy-analytics-platform-preview
🔇 Additional comments (17)
.github/workflows/deploy-frontend-pr-previews.yml (17)
64-95: Update File Path Conditions in File-Check Loop
The conditional checks in thewhileloop have been updated to match files under the newsrc/folder (for netmanager, calibrate, platform, docs, website, website2, inventory, and reports). Please verify that these patterns correctly cover all intended frontend components.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 86-86: trailing spaces
(trailing-spaces)
[error] 90-90: trailing spaces
(trailing-spaces)
119-119: Netmanager .env File Path Update
The command now writes the secret tosrc/netmanager/.env, which aligns with the new project structure.
126-126: Netmanager Directory Change for Build
Thecd src/netmanager/command ensures that build and install operations occur in the correct folder. This is consistent with the updated layout.
139-139: Netmanager Docker Build Directory Update
Changing the working directory tosrc/netmanager/in the Docker build step is correctly aligned with the new structure.
206-206: Calibrate App .env File Path Update
The command now creates the.envfile atsrc/calibrate/.env, reflecting the updated folder structure.
213-213: Calibrate App Build Directory Change
Changing the directory tosrc/calibrate/for npm installation and build is consistent with the reorganization.
293-293: Analytics Platform .env File Path Update
The updated command now writes tosrc/platform/.env. This change correctly reflects the new location for the analytics platform code.
304-304: Analytics Platform Build Directory Update
Changing the working directory tosrc/platform/for building the Docker image is correct under the new file organization.
369-369: Inventory .env File Path Update
The secret is now directed tosrc/inventory/.env, matching the new project structure.
380-380: Inventory Build Directory Change
Updating the directory tosrc/inventory/for building the Docker image is consistent with the revised layout.
455-455: Docs Build Directory Update
Thecd src/docs/command now reflects the location of the docs within thesrcfolder.
530-530: Website JSON Credentials Directory Update
Thedirparameter for creating the Google application credentials file is updated tosrc/website/, which is correct after the reorganization.
534-534: Website App Build Directory Update
Changing the directory tosrc/website/when creating app configuration files (app.yaml and .env.yaml) is appropriate for the new structure.
644-644: Website2 JSON Credentials Directory Update
The updateddirparameter now correctly points tosrc/website2/.
648-648: Website2 App Build Directory Update
Using the commandcd src/website2/ensures that subsequent build steps run in the proper directory.
733-733: Reports .env File Path Update
The .env file for the reports service is now created atsrc/reports/.env, consistent with the new file organization.
744-744: Reports Build Directory Change
Changing the directory tosrc/reports/for building the Docker image aligns with the updated project structure.
|
New netmanager changes available for preview here |
Summary of Changes (What does this PR do?)
Summary by CodeRabbit