Fix Deployment Website #2503
Fix Deployment Website #2503
Conversation
BenjaminSsempala
requested review from
Baalmart,
OchiengPaul442 and
Psalmz777
📝 WalkthroughWalkthroughThe workflow file has been updated to improve the deletion process for old application versions. The changes add a retry mechanism with checks for ongoing operations using Changes
Sequence Diagram(s)sequenceDiagram
participant WF as Workflow
participant GC as GCloud
participant LM as Logger
Note over WF: Start deletion for a version
WF->>GC: List ongoing operations
GC-->>WF: Return operations list
alt Operations in progress
WF->>WF: Wait 30 seconds
else No operations
WF->>GC: Attempt deletion (try 1/3)
GC-->>WF: Deletion result
alt Deletion failed
WF->>WF: Wait 10 seconds and retry
WF->>GC: Attempt deletion (try 2/3)
GC-->>WF: Deletion result
alt Deletion failed again
WF->>WF: Wait 10 seconds and retry
WF->>GC: Attempt deletion (try 3/3)
GC-->>WF: Final deletion result
end
else Deletion succeeded
WF->>LM: Log success message
end
end
Possibly related PRs
Suggested reviewers
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/deploy-frontends-to-production.yml (1)
327-357: Enhanced Retry Mechanism for Deleting Old Versions in Website2 JobThe new logic here introduces a robust retry loop that checks for any ongoing operations before attempting to delete old versions. The mechanism retries deletion up to three times—with a 30-second wait when another operation is detected (line 337–340) and a 10-second delay between deletion attempts (line 346–348). This significantly improves the resilience of the deployment process.
I recommend, as a refinement, considering capturing the output of the
gcloud app operations listcommand into a variable before the loop to avoid executing it repeatedly in each iteration. This could improve performance and readability.
There was a problem hiding this comment.
Thanks @BenjaminSsempala , let me merge. cc: @OchiengPaul442
Summary of Changes (What does this PR do?)
Summary by CodeRabbit