move to production #2976

Baalmart · 2025-10-16T06:29:58Z

…e-category logic

…eta; avoid leaking page into DeviceRegistry calls.

…rguments[0].

Update sites and devices to use Cohorts APIs in data download in analytics

coderabbitai · 2025-10-16T06:30:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch staging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull Request Overview

This PR implements production deployment changes by adding environment-specific group ID configuration and consolidating device/site data fetching to use cohort-based APIs instead of separate category-specific endpoints.

Added production/staging group ID constants with environment-based selection
Replaced category-specific device hooks with unified cohort-based fetching
Added new gas device category support and API endpoints for cohort-based data

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/platform/src/lib/constants.js	Added environment-based AirQo group ID configuration
src/platform/src/core/utils/loginSetup.js	Simplified user group fallback logic using environment-specific group ID
src/platform/src/core/urls/deviceRegistry.js	Added new cohort-based API endpoints for devices and sites
src/platform/src/core/urls/authentication.js	Added group cohorts URL helper function
src/platform/src/core/hooks/usePaginatedData.js	Major refactor: replaced device category hooks with unified cohort-based fetching
src/platform/src/core/hooks/analyticHooks.js	Removed exports for deprecated device category hooks
src/platform/src/core/apis/DeviceRegistry.js	Added cohort-based API functions for devices and sites
src/platform/src/core/apis/Analytics.js	Added category parameter support to device summary API
src/platform/src/core/apis/Account.js	Added group cohorts API function
src/platform/src/common/features/download-insights-locations/more-insights/hooks/useDownload.js	Added device category parameter support
src/platform/src/common/features/download-insights-locations/data-download/hooks/useDataDownloadLogic.js	Added 'gas' to valid device categories
src/platform/src/common/features/download-insights-locations/data-download/constants.js	Added gas device category option
src/platform/src/common/features/download-insights-locations/data-download/components/DataContent.js	Extended device category support to include gas sensors
src/platform/src/common/features/download-insights-locations/data-download/DataDownload.jsx	Major refactor: consolidated device category hooks into unified approach
src/platform/src/common/features/download-insights-locations/components/DataTable.jsx	Added activeFilterKey prop support for filter synchronization
src/platform/src/common/features/analytics-overview/hooks/useAnalyticsDownload.js	Added device category parameter to download function

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T06:30:56Z

src/platform/src/core/apis/DeviceRegistry.js

+  cohort_ids = [],
+  skip = 0,
+  limit = 30,
+  search='',


Missing space after the default value assignment. Should be search = '', for consistency with other parameters.

@Codebmk ..... please note in your next PRs...

Copilot · 2025-10-16T06:30:56Z

src/platform/src/core/apis/DeviceRegistry.js

+  cohort_ids = [],
+  skip = 0,
+  limit = 30,
+  search='',


Missing space after the default value assignment. Should be search = '', for consistency with other parameters.

Copilot · 2025-10-16T06:30:57Z

src/platform/src/core/hooks/usePaginatedData.js

+          const cohortIds = extractCohortIds(cohortsResponse);
+
+          if (cohortIds.length === 0) {
+            return { sites: [], meta: { total: 0, totalPages: 0, page: 1, limit: params.limit || 20, hasNextPage: false, hasPreviousPage: false } };


This long object literal should be extracted to a helper function or constant to improve readability and reduce duplication (appears on lines 362 and 426).

@Codebmk ..... please note in your next PRs...

Copilot · 2025-10-16T06:30:57Z

src/platform/src/core/hooks/usePaginatedData.js

+          const cohortIds = extractCohortIds(cohortsResponse);
+
+          if (cohortIds.length === 0) {
+            return { devices: [], meta: { total: 0, totalPages: 0, page: 1, limit: params.limit || 20, hasNextPage: false, hasPreviousPage: false } };


This duplicated empty response structure should be extracted to a helper function to reduce code duplication.

@Codebmk ..... please note in your next PRs...

Copilot · 2025-10-16T06:30:57Z

src/platform/src/common/features/download-insights-locations/components/DataTable.jsx

+        setColumnFilters({});    
+        setCurrentPage(1);       


Inconsistent trailing whitespace on these lines. Remove the extra spaces for clean formatting.

@Codebmk ..... please note in your next PRs...

Fix reset password in analytics

Codebmk and others added 18 commits October 14, 2025 16:45

New device swummary api

f8520f8

api replace

7765211

fix arrangement of params, Sync activeFilter with external prop updates

17bbc5b

missing gas device category

a8b3cd0

code fixes

ba767e7

Pass the actual error object to getApiErrorMessage

62fdecd

Critical: signal parameter placed incorrectly.

8bca60d

Update usePaginatedData.js

31865c8

Update usePaginatedData.js

691d965

missing category

a7f26bf

Update usePaginatedData.js

6a0da44

use dynamic device category value - Extend 'gas' support across devic…

82d96a7

…e-category logic

Don’t wrap abort errors; harden cohort ID extraction; return zeroed m…

2bac229

…eta; avoid leaking page into DeviceRegistry calls.

Refactor: Add deviceCategory to function signature instead of using a…

f73867b

…rguments[0].

Guard against undefined limit in meta.

5624bcc

Guard against undefined limit in meta.

f00ff6d

Update page.jsx

70d9d2a

Merge pull request #2975 from airqo-platform/cohorts-data-download

159feb4

Update sites and devices to use Cohorts APIs in data download in analytics

Baalmart requested review from Codebmk and OchiengPaul442 October 16, 2025 06:29

Baalmart added the work in progress label Oct 16, 2025

Baalmart requested a review from Copilot October 16, 2025 06:30

Copilot AI reviewed Oct 16, 2025

View reviewed changes

github-actions bot and others added 6 commits October 16, 2025 09:32

Update next platform staging image tag to stage-159feb46-1760596116

0b13494

fix password reset error format

27ba3cf

Fix prop name: CustomToast expects onDismiss, not onClose.

297b0f1

Memory leak: showToast timeouts are not cleaned up.

39efc5d

Merge pull request #2977 from airqo-platform/fix-reset-password

90baac2

Fix reset password in analytics

Update next platform staging image tag to stage-90baac23-1760607572

fb10229

Baalmart added ready for review and removed work in progress labels Oct 16, 2025

Baalmart merged commit 82761b9 into master Oct 16, 2025
4 checks passed

move to production #2976

move to production #2976

Uh oh!

Conversation

Baalmart commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Baalmart Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Baalmart Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Baalmart Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Baalmart Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Baalmart commented Oct 16, 2025 •

edited

Loading

coderabbitai bot commented Oct 16, 2025 •

edited

Loading