Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Github actions on releases #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

djjudas21
Copy link

  • Run the release pipeline only on tags/releases, and use the tag on the Docker image too, instead of hard-coding 1.0.0
  • Add a simple CI pipeline on every commit to run basic go and npm tests. Please note the npm tests are currently failing, but I think this is a problem with the code rather than the pipeline.

Hope this helps improve the devops on this project 😄
Part of #91

Run release pipeline on tags
@djjudas21
Copy link
Author

Hey, is there any progress on this issue? I see you're still deploying a hard-coded tag of 1.0.0 to Docker Hub https://hub.docker.com/r/akhilrex/hammond/tags

It would really help me maintain the Helm chart if you would consider using semver releases 😄

@djjudas21
Copy link
Author

Hey @akhilrex, please would you consider merging this? It would improve the project workflow so much, and it will make my Helm chart more reliable, which will get more users using it.

@AlfHou
Copy link
Contributor

AlfHou commented Nov 19, 2022

@djjudas21 I think we might need to consider forking this project. I think the project would really benefit of more people being able to review and merge changes. Feel free to upstream the changes to my fork and I'll pull them in.

@djjudas21
Copy link
Author

Thanks @AlfHou. I've submitted AlfHou#1 against your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants