16.0

account_usability/account.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import models, fields, api, _
-from odoo.tools import float_compare, float_is_zero
+from odoo.tools import float_compare, float_is_zero, float_round
 from odoo.tools.misc import formatLang
 from odoo.exceptions import UserError, ValidationError
 from odoo.osv import expression
@@ -407,6 +407,58 @@ def _compute_default_credit_debit(self):
             move.default_credit = default_credit
             move.default_debit = default_debit
 
+    @api.model
+    def _fix_debit_credit_round_bug(self):
+        logger.info('START script _fix_debit_credit_round_bug')
+        moves = self.sudo().search([])  # sudo to search in all companies
+        bug_move_ids = []
+        for move in moves:
+            buggy = False
+            for l in move.line_ids:
+                if not float_is_zero(l.debit, precision_digits=2):
+                    debit_rounded = float_round(l.debit, precision_digits=2)
+                    if float_compare(l.debit, debit_rounded, precision_digits=6):
+                        logger.info('Bad move to fix ID %d company_id %d name %s ref %s date %s journal %s (line ID %d debit=%s)', move.id, move.company_id.id, move.name, move.ref, move.date, move.journal_id.code, l.id, l.debit)
+                        buggy = True
+                        break
+                else:
+                    credit_rounded = float_round(l.credit, precision_digits=2)
+                    if float_compare(l.credit, credit_rounded, precision_digits=6):
+                        logger.info('Bad move to fix ID %d company_id %d name %s ref %s date %s journal %s (line ID %d credit=%s)', move.id, move.company_id.id, move.name, move.ref, move.date, move.journal_id.code, l.id, l.credit)
+                        buggy = True
+                        break
+            if buggy:
+                bug_move_ids.append(move.id)
+                bal = 0.0
+                max_credit = (False, 0)
+                for l in move.line_ids:
+                    if not float_is_zero(l.debit, precision_digits=2):
+                        new_debit = float_round(l.debit, precision_digits=2)
+                        self._cr.execute(
+                            'UPDATE account_move_line set debit=%s, balance=%s where id=%s',
+                            (new_debit, new_debit, l.id))
+                        bal -= new_debit
+                    elif not float_is_zero(l.credit, precision_digits=2):
+                        new_credit = float_round(l.credit, precision_digits=2)
+                        self._cr.execute(
+                            'UPDATE account_move_line set credit=%s, balance=%s where id=%s',
+                            (new_credit, new_credit * -1, l.id))
+                        bal += new_credit
+                        if new_credit > max_credit[1]:
+                            max_credit = (l, new_credit)
+                if not float_is_zero(bal, precision_digits=2):
+                    assert abs(bal) < 0.05
+                    l = max_credit[0]
+                    new_credit = max_credit[1]
+                    new_new_credit = float_round(new_credit - bal, precision_digits=2)
+                    assert new_new_credit > 0
+                    self._cr.execute(
+                        'UPDATE account_move_line set credit=%s, balance=%s where id=%s',
+                        (new_new_credit, new_new_credit * -1, l.id))
+                logger.info('Move ID %d fixed', move.id)
+        logger.info('%d buggy moves fixed (IDs: %s)', len(bug_move_ids), bug_move_ids)
+        logger.info('END _fix_debit_credit_round_bug')
+
 
 class AccountMoveLine(models.Model):
     _inherit = 'account.move.line'
@@ -672,6 +724,16 @@ def name_get(self):
             res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
         return res
 
+    @api.model
+    def name_search(self, name='', args=None, operator='ilike', limit=80):
+        if args is None:
+            args = []
+        if name and operator == 'ilike':
+            recs = self.search([('code', '=', name)] + args, limit=limit)
+            if recs:
+                return recs.name_get()
+        return super().name_search(name=name, args=args, operator=operator, limit=limit)
+
 
 class AccountReconciliation(models.AbstractModel):
     _inherit = 'account.reconciliation.widget'
@@ -704,3 +766,22 @@ class ResConfigSettings(models.TransientModel):
 
     transfer_account_id = fields.Many2one(
         related='company_id.transfer_account_id', readonly=False)
+
+
+class AccountChartTemplate(models.Model):
+    _inherit = "account.chart.template"
+
+    @api.model
+    def _prepare_transfer_account_template(self):
+        """Change the type of default account in order to be
+        compliant with _check_account_type_on_bank_journal
+        Used at installation of payment modules like stripe
+        See https://github.com/akretion/odoo-usability/issues/115
+        """
+        vals = super()._prepare_transfer_account_template()
+        current_assets_type = self.env.ref(
+            'account.data_account_type_liquidity', raise_if_not_found=False)
+        vals.update({
+            'user_type_id': current_assets_type and current_assets_type.id or False,
+        })
+        return vals

account_usability/readme/DESCRIPTION.rst

@@ -31,6 +31,7 @@ This modules adds the following functions:
 * don't attach PDF upon invoice report generation on supplier invoices/refunds
 * Add filter on debit and credit amount for Move Lines
 * Add supplier invoice number in invoice tree view
+* Change type from current_assets to  liquidity for transfert account template.
 
 Together with this module, I recommend the use of the following modules:
 

base_dynamic_list/__init__.py

@@ -0,0 +1 @@
+from . import models

base_dynamic_list/__manifest__.py

@@ -0,0 +1,62 @@
+# Copyright 2020-2022 Akretion France (http://www.akretion.com)
+# @author Alexis de Lattre <[email protected]>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+{
+    'name': 'Base Dynamic List',
+    'version': '12.0.1.0.0',
+    'category': 'Tools',
+    'license': 'AGPL-3',
+    'summary': 'Dynamic lists',
+    'description': """
+Base Dynamic List
+=================
+
+Very often during an Odoo implementation, we need to add selection fields on a native objet, and we don't want to have a hard-coded selection list (fields.Selection), but a selection list that can be changed by users (Many2one field). For that, the developper needs to add a new object (with just a 'name' and 'sequence' field) with a form/tree view. The goal of this module is to speed-up this process by defining a dynamic list object that already has all the required views.
+
+This module provides several ready-to-go objects:
+
+* simple list : fields *name*, *sequence* and *active*
+* translatable list : fields *name* with translate=True, *sequence* and *active*
+* code list : fields *code* (unique), *name*, *sequence* and *active*
+* translatable code list : fields *code* (unique), *name* with translate=True, *sequence* and *active*
+
+These objects are readable by the employee group. The system group has full rights on it.
+
+To use it, you need to do 2 or 3 things :
+
+1) Add an entry in the domain field and the object you selected:
+
+domain = fields.Selection(selection_add=[('risk.type', "Risk Type")], ondelete={"risk.type": "cascade"})
+
+2) Add the many2one field on your object:
+
+risk_type_id = fields.Many2one(
+    'dynamic.list', string="Risk Type",
+    ondelete='restrict', domain=[('domain', '=', 'risk.type')])
+
+
+3) Optionally, you can add a dedicated action and a menu entry (otherwize, you can use the generic menu entry under *Settings > Technical > Dynamic Lists*:
+
+<record id="dynamic_list_risk_type_action" model="ir.actions.act_window">
+    <field name="name">Risk Type</field>
+    <field name="res_model">dynamic.list</field>
+    <field name="view_mode">tree,form</field>
+    <field name="domain">[('domain', '=', 'risk.type')]</field>
+    <field name="context">{'default_domain': 'risk.type'}</field>
+</record>
+
+<menuitem id="dynamic_list_risk_type_menu" action="dynamic_list_risk_type_action"
+parent="parent_menu_xmlid"/>
+
+Limitation: when you want to have different access rights on these lists depending on the source object, you should prefer to use dedicated objects.
+""",
+    'author': 'Akretion',
+    'website': 'http://www.akretion.com',
+    'depends': ['base'],
+    'data': [
+        'security/ir.model.access.csv',
+        'views/dynamic_list.xml',
+        ],
+    'installable': True,
+}

base_dynamic_list/models/__init__.py

@@ -0,0 +1 @@
+from . import dynamic_list

base_dynamic_list/models/dynamic_list.py

@@ -0,0 +1,115 @@
+# Copyright 2020-2022 Akretion France (http://www.akretion.com)
+# @author Alexis de Lattre <[email protected]>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from odoo import api, fields, models
+
+
+class DynamicList(models.Model):
+    _name = 'dynamic.list'
+    _description = 'Dynamic List (non translatable)'
+    _order = 'sequence, id'
+
+    name = fields.Char(required=True)
+    sequence = fields.Integer(default=10)
+    active = fields.Boolean(default=True)
+    domain = fields.Selection([], string='Domain', required=True, index=True)
+
+    _sql_constraint = [(
+        'domain_name_uniq',
+        'unique(domain, name)',
+        'This entry already exists!'
+        )]
+
+
+class DynamicListTranslate(models.Model):
+    _name = 'dynamic.list.translate'
+    _description = 'Translatable Dynamic List'
+    _order = 'sequence, id'
+
+    name = fields.Char(translate=True, required=True)
+    sequence = fields.Integer(default=10)
+    active = fields.Boolean(default=True)
+    domain = fields.Selection([], string='Domain', required=True, index=True)
+
+    _sql_constraint = [(
+        'domain_name_uniq',
+        'unique(domain, name)',
+        'This entry already exists!'
+        )]
+
+
+class DynamicListCode(models.Model):
+    _name = 'dynamic.list.code'
+    _description = 'Dynamic list with code'
+    _order = 'sequence, id'
+
+    code = fields.Char(required=True)
+    name = fields.Char(translate=True, required=True)
+    sequence = fields.Integer(default=10)
+    active = fields.Boolean(default=True)
+    domain = fields.Selection([], string='Domain', required=True, index=True)
+
+    _sql_constraint = [(
+        'domain_code_uniq',
+        'unique(domain, code)',
+        'This code already exists!'
+        )]
+
+    @api.depends('code', 'name')
+    def name_get(self):
+        res = []
+        for rec in self:
+            res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
+        return res
+
+    @api.model
+    def name_search(
+            self, name='', args=None, operator='ilike', limit=80):
+        if args is None:
+            args = []
+        if name and operator == 'ilike':
+            recs = self.search(
+                [('code', '=', name)] + args, limit=limit)
+            if recs:
+                return recs.name_get()
+        return super().name_search(
+            name=name, args=args, operator=operator, limit=limit)
+
+
+class DynamicListCodeTranslate(models.Model):
+    _name = 'dynamic.list.code.translate'
+    _description = 'Translatable dynamic list with code'
+    _order = 'sequence, id'
+
+    code = fields.Char(required=True)
+    name = fields.Char(translate=True, required=True)
+    sequence = fields.Integer(default=10)
+    active = fields.Boolean(default=True)
+    domain = fields.Selection([], string='Domain', required=True, index=True)
+
+    _sql_constraint = [(
+        'domain_code_uniq',
+        'unique(domain, code)',
+        'This code already exists!'
+        )]
+
+    @api.depends('code', 'name')
+    def name_get(self):
+        res = []
+        for rec in self:
+            res.append((rec.id, '[%s] %s' % (rec.code, rec.name)))
+        return res
+
+    @api.model
+    def name_search(
+            self, name='', args=None, operator='ilike', limit=80):
+        if args is None:
+            args = []
+        if name and operator == 'ilike':
+            recs = self.search(
+                [('code', '=', name)] + args, limit=limit)
+            if recs:
+                return recs.name_get()
+        return super().name_search(
+            name=name, args=args, operator=operator, limit=limit)

base_dynamic_list/security/ir.model.access.csv

@@ -0,0 +1,9 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_dynamic_list_read,Read access on dynamic.list to employees,model_dynamic_list,base.group_user,1,0,0,0
+access_dynamic_list_full,Full access to dynamic.list to System group,model_dynamic_list,base.group_system,1,1,1,1
+access_dynamic_list_translate_read,Read access on dynamic.list.translate to employees,model_dynamic_list_translate,base.group_user,1,0,0,0
+access_dynamic_list_translate_full,Full access to dynamic.list.translate to System group,model_dynamic_list_translate,base.group_system,1,1,1,1
+access_dynamic_list_code_read,Read access on dynamic.list.code to employees,model_dynamic_list_code,base.group_user,1,0,0,0
+access_dynamic_list_code_full,Full access to dynamic.list.code to System group,model_dynamic_list_code,base.group_system,1,1,1,1
+access_dynamic_list_code_translate_read,Read access on dynamic.list.code.translate to employees,model_dynamic_list_code_translate,base.group_user,1,0,0,0
+access_dynamic_list_code_translate_full,Full access to dynamic.list.code.translate to System group,model_dynamic_list_code_translate,base.group_system,1,1,1,1