Merge branch 'develop' into devsecops

aleks-ivanov · Jan 26, 2025 · aa3baca · aa3baca
2 parents 0d22ee2 + 65b616a
commit aa3baca
Show file tree

Hide file tree

Showing 8 changed files with 53 additions and 5 deletions.
diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/CheckBoxFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/CheckBoxFormFieldBuilderTest.cs
@@ -60,6 +60,12 @@ public virtual void CreateCheckBoxWithWidgetTest() {
             CompareCheckBoxes(checkBoxFormField, true);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateCheckBoxWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new CheckBoxFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateCheckBox());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateCheckBoxWithoutWidgetTest() {
             PdfButtonFormField checkBoxFormField = new CheckBoxFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).CreateCheckBox

diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/ChoiceFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/ChoiceFormFieldBuilderTest.cs
@@ -107,6 +107,12 @@ public virtual void CreateComboBoxWithoutWidgetTest() {
             CompareChoices(new PdfDictionary(), choiceFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateComboBoxWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateComboBox());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateComboBoxWithConformanceLevelTest() {
             PdfChoiceFormField choiceFormField = new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle
@@ -147,6 +153,12 @@ public virtual void CreateListWithoutWidgetTest() {
             CompareChoices(expectedDictionary, choiceFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateListWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateList());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateListWithConformanceLevelTest() {
             PdfChoiceFormField choiceFormField = new ChoiceFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle

diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/PushButtonFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/PushButtonFormFieldBuilderTest.cs
@@ -66,6 +66,12 @@ public virtual void CreatePushButtonWithoutWidgetTest() {
             ComparePushButtons(pushButtonFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreatePushButtonWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new PushButtonFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name")
+                .SetWidgetRectangle(DUMMY_RECTANGLE).CreatePushButton());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreatePushButtonWithConformanceLevelTest() {
             PdfButtonFormField pushButtonFormField = new PushButtonFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle

diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/RadioFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/RadioFormFieldBuilderTest.cs
@@ -66,6 +66,12 @@ public virtual void CreateRadioButtonWithWidgetTest() {
             CompareRadioButtons(radioAnnotation, radioGroup, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateRadioButtonWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new RadioFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateRadioGroup());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateRadioButtonWithWidgetUseSetWidgetRectangleTest() {
             RadioFormFieldBuilder builder = new RadioFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME);

diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/SignatureFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/SignatureFormFieldBuilderTest.cs
@@ -59,6 +59,12 @@ public virtual void CreateSignatureWithoutWidgetTest() {
             CompareSignatures(signatureFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateSignatureWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new SignatureFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").
+                SetWidgetRectangle(DUMMY_RECTANGLE).CreateSignature());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateSignatureWithConformanceLevelTest() {
             PdfSignatureFormField signatureFormField = new SignatureFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle

diff --git a/itext.tests/itext.forms.tests/itext/forms/fields/TextFormFieldBuilderTest.cs b/itext.tests/itext.forms.tests/itext/forms/fields/TextFormFieldBuilderTest.cs
@@ -62,6 +62,12 @@ public virtual void CreateTextWithoutWidgetTest() {
             CompareTexts(expectedDictionary, textFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateTextWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new TextFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateText());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateTextWithConformanceLevelTest() {
             PdfTextFormField textFormField = new TextFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle(DUMMY_RECTANGLE
@@ -89,6 +95,12 @@ public virtual void CreateMultilineTextWithoutWidgetTest() {
             CompareTexts(expectedDictionary, textFormField, false);
         }
 
+        [NUnit.Framework.Test]
+        public virtual void CreateMultilineTextWithIncorrectNameTest() {
+            NUnit.Framework.Assert.DoesNotThrow(() => new TextFormFieldBuilder(DUMMY_DOCUMENT, "incorrect.name").SetWidgetRectangle
+                (DUMMY_RECTANGLE).CreateMultilineText());
+        }
+
         [NUnit.Framework.Test]
         public virtual void CreateMultilineTextWithConformanceLevelTest() {
             PdfTextFormField textFormField = new TextFormFieldBuilder(DUMMY_DOCUMENT, DUMMY_NAME).SetWidgetRectangle(DUMMY_RECTANGLE

diff --git a/itext/itext.forms/itext/forms/fields/PdfFormAnnotation.cs b/itext/itext.forms/itext/forms/fields/PdfFormAnnotation.cs
@@ -815,7 +815,7 @@ protected internal virtual void DrawListFormFieldAndSaveAppearance() {
             bool multiselect = parent.GetFieldFlag(PdfChoiceFormField.FF_MULTI_SELECT);
             if (!(formFieldElement is ListBoxField)) {
                 // Create it once and reset properties during each widget regeneration.
-                formFieldElement = new ListBoxField(parent.GetPartialFieldName().ToUnicodeString(), 0, multiselect);
+                formFieldElement = new ListBoxField("", 0, multiselect);
             }
             formFieldElement.SetProperty(FormProperty.FORM_FIELD_MULTIPLE, multiselect);
             ((ListBoxField)formFieldElement).SetTopIndex(parent is PdfChoiceFormField && ((PdfChoiceFormField)parent).
@@ -956,7 +956,7 @@ protected internal virtual void DrawComboBoxAndSaveAppearance() {
                 return;
             }
             if (!(formFieldElement is ComboBoxField)) {
-                formFieldElement = new ComboBoxField(parent.GetPartialFieldName().ToUnicodeString());
+                formFieldElement = new ComboBoxField("");
             }
             //Apply rotation
             int fieldRotation = GetRotation();
@@ -1156,7 +1156,7 @@ private bool FontRequiredForRegeneration() {
         internal virtual void CreateInputButton() {
             if (!(formFieldElement is Button)) {
                 // Create it one time and re-set properties during each widget regeneration.
-                formFieldElement = new Button(parent.GetPartialFieldName().ToUnicodeString());
+                formFieldElement = new Button("");
             }
             ((Button)formFieldElement).SetFont(GetFont());
             if (GetColor() != null) {
@@ -1169,7 +1169,7 @@ internal virtual void CreateInputButton() {
         internal virtual void CreateSigField() {
             if (!(formFieldElement is SignatureFieldAppearance)) {
                 // Create it one time and re-set properties during each widget regeneration.
-                formFieldElement = new SignatureFieldAppearance(parent.GetPartialFieldName().ToUnicodeString());
+                formFieldElement = new SignatureFieldAppearance("");
             }
             if (formFieldElement.GetProperty<Object>(Property.FONT) == null) {
                 ((SignatureFieldAppearance)formFieldElement).SetFont(GetFont());

diff --git a/port-hash b/port-hash
@@ -1 +1 @@
-06babfa08baa6bb10548c0cf92f7749039e401b5
+45554228c115f16152064c2fe9580e0542dd381e
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		06babfa08baa6bb10548c0cf92f7749039e401b5
		45554228c115f16152064c2fe9580e0542dd381e