Fix: error 500 on get_credit_balances_handler

[1yam]

Self proofreading checklist

• Is my code clear enough and well documented
• Are my files well typed
• New translations have been added or updated if new strings have been introduced in the frontend
• Database migrations file are included
• Are there enough tests
• Documentation has been included (for new feature)

Changes

This pull request makes a small change to how credit balances are formatted in the get_credit_balances_handler function. Instead of using the model_validate method, it now explicitly creates AddressCreditBalanceResponse objects using the address and credits values from each balance.

How to test

http://46.255.204.204:4024/api/v0/credit_balances # WORKING
https://api2.aleph.im/api/v0/credit_balances # ERROR 500

[Copilot]

Pull request overview

Fixes the /api/v0/credit_balances 500 by adjusting how DB credit balance rows are converted into API response models, and by tightening the DB accessor function signatures.

Changes:

• Build AddressCreditBalanceResponse from (address, balance) tuple values instead of calling model_validate on DB rows.
• Update count_credit_balances invocation to pass only min_balance.
• Tighten DB accessor type hints/signatures for get_credit_balances and count_credit_balances.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/aleph/web/controllers/accounts.py	Fixes response formatting for credit balances and updates total-count call signature.
src/aleph/db/accessors/balances.py	Tightens credit balance accessor/count signatures and adds explicit return typing.

Comments suppressed due to low confidence (1)

src/aleph/db/accessors/balances.py:394

• count_credit_balances signature was tightened (removed **kwargs), so incorrect callers will now fail fast. Add focused tests around min_balance filtering/counting so the handler's pagination_total behavior is locked in and stays consistent with get_credit_balances.

def count_credit_balances(session: DbSession, min_balance: int = 0) -> int:
    """
    Count addresses with credit balances.
    Uses the cached balances from the credit_balances table.
    """

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This change fixes a production 500 by altering how the endpoint formats DB rows and how the total is computed. There are controller tests in tests/web/controllers/test_accounts_controllers.py, but none covering /credit_balances; please add a regression test for get_credit_balances_handler that exercises the response formatting and min_balance filtering/counting to prevent this from reoccurring.