-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Use subscripts for small amounts #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d580a2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I'm back from my holidays!
Very good job 👏
I'll do some functional tests next, in the meantime would you mind having a look at the small comments I have?
58ea9ec to
c511f37
Compare
Welcome back @nop33 ! I have made the corrections |
nop33
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply!
One issue I found when testing the apps is that the color fo the subscript doesn't follow the color of the rest of the amount text. The following screenshot is an example of the transactions list amounts in the desktop wallet. Since it's an incoming transaction, the wallet changes the color of the amount to green, but the subscript amount remains gray. Could you please have a look?
PS: On mobile wallet it seems that it works correctly
|
Hi @nop33 , I have update the color to inherit the parent's |
|
Thanks a lot for this contribution! |
It's always a pleasure! |
Closes #951
Description
This PR implements subscript notation for displaying very small amounts (e.g.,
0.0₅1instead of0.000001) across the Mobile Wallet, Desktop Wallet, and Explorer. This improves readability for token amounts with many leading zeros.Changes
Verification
pnpm test packages/shared)pnpm check)