Merge write branch; add write multiple method.#30
Conversation
|
Thanks for taking the time adding some of the implementation that I haven't gotten around too. I'll look it over as soon as I can and provide feedback. Are you testing on a bacnet controller? |
|
@alexbeltran |
alexbeltran
left a comment
alexbeltran
left a comment
There was a problem hiding this comment.
First pass, there are still 17 files I haven't looked at.
| import "github.com/alexbeltran/gobacnet/types" | ||
|
|
||
| /* returns the fixed tag type for certain context tagged properties */ | ||
| func tagTypeInContext(property types.PropertyType, tagNumber uint8) uint8 { |
| @@ -0,0 +1,95 @@ | |||
| // +build MSTP | |||
There was a problem hiding this comment.
Looks like a WIP. Before removing this tag, I would like to remove the cgo dependency to keep this library pure go. For now this is fine though since I imagine that is a bit of work.
There was a problem hiding this comment.
If this is a WIP that you want useable, could you add this to the readme as well.
There was a problem hiding this comment.
What do you mean by WIP？
MS/TP is another datalink based on serial port 485 and its implemention seems very complex, so I use a C library directly for a temporary solution. To be implemented by pure go.
There was a problem hiding this comment.
you can ignore this file.
If not set -tags MSTP, this file won't be compiled
2 participants
Merge write branch;
Add write multiple method.
Refactor and extract datalink.
TODO: mstp to be implemented.