fix for ObjectMap UnmarshalJSON dereferencing a nil pointer#33
Open
jb0n wants to merge 14 commits into
Open
Conversation
added 12 commits
June 2, 2022 13:00
request.go to return an error when we get one back instead of nil.
good to me so far)
alexbeltran
requested changes
May 9, 2024
alexbeltran
left a comment
alexbeltran
left a comment
Owner
There was a problem hiding this comment.
Thanks for contributing. It looks like you've change the package name to your local branch to your own branch. Please change all references to jb0n back to alexbeltran.
Also, there seems to be a few unrelated changes, do you mind breaking this pull request into smaller pieces.
| # Installation | ||
| Part of this library is a command line client. To install from source run: | ||
| ``` | ||
| go get -u github.com/alexbeltran/gobacnet/baccli |
| expectedTag = 4 | ||
| if tag != expectedTag { | ||
| return &ErrorIncorrectTag{Expected: expectedTag, Given: tag} | ||
| OUTER: |
Author
|
Oh hello. I had kind of forgotten about the pull request to be honest. It's
kind of old. I'm just using this lib (for work) and fixing things as they
pop up. I can roll out all those changes to import names I landed to
master/the PR today if you have some interest in meeting it though.
…On Wed, May 8, 2024, 6:55 PM Alex Beltran ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for contributing. It looks like you've change the package name to
your local branch to your own branch. Please change all references to jb0n
back to alexbeltran.
Also, there seems to be a few unrelated changes, do you mind breaking this
pull request into smaller pieces.
------------------------------
In README.md
<#33 (comment)>:
> @@ -13,7 +12,7 @@ missing and will be added overtime.
# Installation
Part of this library is a command line client. To install from source run:
```
-go get -u github.com/alexbeltran/gobacnet/baccli
Revert name back.
------------------------------
In encoding/readmultipleack.go
<#33 (comment)>:
> expectedTag = 4
- if tag != expectedTag {
- return &ErrorIncorrectTag{Expected: expectedTag, Given: tag}
+ OUTER:
Is this required?
—
Reply to this email directly, view it on GitHub
<#33 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALDTP66VCKT377UL4SQMB3ZBLJSLAVCNFSM5XWCI4YKU5DIOJSWCZC7NNSXTPCQOVWGYUTFOF2WK43UKJSXM2LFO45TEMBUG4YDCNRVGMYQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Oh sorry! It popped in my inbox recently. It would be nice, but I
understand if you have moved on. :)
…On May 8, 2024 at 7:30:42 PM, jb0n ***@***.***> wrote:
Oh hello. I had kind of forgotten about the pull request to be honest.
It's
kind of old. I'm just using this lib (for work) and fixing things as they
pop up. I can roll out all those changes to import names I landed to
master/the PR today if you have some interest in meeting it though.
On Wed, May 8, 2024, 6:55 PM Alex Beltran ***@***.***> wrote:
> ***@***.**** requested changes on this pull request.
>
> Thanks for contributing. It looks like you've change the package name to
> your local branch to your own branch. Please change all references to
jb0n
> back to alexbeltran.
>
> Also, there seems to be a few unrelated changes, do you mind breaking
this
> pull request into smaller pieces.
> ------------------------------
>
> In README.md
> <#33 (comment)>:
>
> > @@ -13,7 +12,7 @@ missing and will be added overtime.
> # Installation
> Part of this library is a command line client. To install from source
run:
> ```
> -go get -u github.com/alexbeltran/gobacnet/baccli
>
> Revert name back.
> ------------------------------
>
> In encoding/readmultipleack.go
> <#33 (comment)>:
>
> > expectedTag = 4
> - if tag != expectedTag {
> - return &ErrorIncorrectTag{Expected: expectedTag, Given: tag}
> + OUTER:
>
> Is this required?
>
> —
> Reply to this email directly, view it on GitHub
> <
#33 (review)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AALDTP66VCKT377UL4SQMB3ZBLJSLAVCNFSM5XWCI4YKU5DIOJSWCZC7NNSXTPCQOVWGYUTFOF2WK43UKJSXM2LFO45TEMBUG4YDCNRVGMYQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFE5ZZGR62CRWNATHQBHLTZBLNVFAVCNFSM5XWCI4YKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJQGE4DCOBTGY2Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
added 2 commits
May 9, 2024 10:38
parsing change and adding a test for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small fix I stumbled on when using this lib