-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Theme for Zendesk Help Center #154
base: master
Are you sure you want to change the base?
Conversation
Hey @peterdj It seems like to do a good job at reviewing the work would require between 1-2 days of commitment to test things thoroughly and give useful feedback or catch problems. Did you have any specific expectations in mind regarding Alphonse's involvement? I have very little knowledge about the project you are working on and the resources available to help you on your side, I would love to have a chat to understand the best way to move forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious to know more about this work too. Why do we want to provide an Algolia Zendesk theme in the first place? Who will be maintaining it?
This project is in very low maintenance mode, there are a few things to update first. I've worked a bit on it today, but it's not the best base yet to start building on top of.
And finally, I join @rayrutjes on the fact that the PR is huge, so having some screenshots, detailed instructions how to test and how to review (what has been imported/generated as-is and can be ignored, what is completely new and needs to be reviewed, ...) are more than welcome.
## Adding the Algolia Help Center Theme | ||
|
||
You can use the Algolia Help Center Theme. You can import the theme from the Zendesk Theme Marketplace. | ||
Also, you can download from here: https://cdn.jsdelivr.net/gh/algolia/algoliasearch-zendesk@new_theme/theme/Algolia-search/Algolia-search.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have the .zip
directly with the source code
|
||
This theme has an admin section where you update your index, keys and other settings | ||
<div align="center"> | ||
<img src="https://cdn.jsdelivr.net/gh/algolia/algoliasearch-zendesk@new_theme/theme/Algolia-search/screenshots/AdminScreen.png" alt="Admin Section" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, won't those links break when we'll delete the branch?
"show_brand_name_label": "Show Help Center name", | ||
"show_brand_name_description": "Display the Help Center name next to the logo", | ||
"algolia_search_settings": "Algolia Search Settings", | ||
"application_id_description": "The Application Id in Algolia", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about all the other translations? What will be displayed by default?
@@ -0,0 +1,44 @@ | |||
|
|||
|
|||
const searchClient = algoliasearch('TEJIG1OP44', 'ceccf5707ee9c36062d2af126551aa8c'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to remove those
This is an update to use a theme that updates the home page of the theme. It has a settings page where you update the name of the index, and decide whether or not to use Autocomplete or not