Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): automate update of java formatter #817

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 12, 2022

🧭 What and Why

A new version allows to simplify the call to the formatter, but I missed the update because renovate wasn't setup for it yet.

@millotp millotp self-assigned this Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4b50a88
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62cd9442d417db00098fce2d
😎 Deploy Preview https://deploy-preview-817--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 12, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp force-pushed the chore/java-formatter-update branch from 326bb92 to e33e3d5 Compare July 12, 2022 14:12
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

},
{
"description": "Update the java formatter",
"fileMatch": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fileMatch works with filename only not paths

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not clear but in some examples they use a real path, I think it's a regex on the entire path, starting from the root directory (example)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I expected too when added the support for mustache files but it was in fact matching filenames 🤔 we can try and see how it goes on Friday I guess!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can check right after merging by checking the box in #532 😉

shortcuts
shortcuts previously approved these changes Jul 12, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe revert the updates and only add the renovate part, so we can know on Friday if it works!

Otherwise good to go :D

@millotp
Copy link
Collaborator Author

millotp commented Jul 12, 2022

good idea !

shortcuts
shortcuts previously approved these changes Jul 12, 2022
@millotp millotp merged commit 10c94dd into main Jul 12, 2022
@millotp millotp deleted the chore/java-formatter-update branch July 12, 2022 15:37
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 12, 2022
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants