-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): automate update of java formatter #817
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
326bb92
to
e33e3d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice!
}, | ||
{ | ||
"description": "Update the java formatter", | ||
"fileMatch": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fileMatch works with filename only not paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear but in some examples they use a real path, I think it's a regex on the entire path, starting from the root directory (example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I expected too when added the support for mustache files but it was in fact matching filenames 🤔 we can try and see how it goes on Friday I guess!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can check right after merging by checking the box in #532 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe revert the updates and only add the renovate part, so we can know on Friday if it works!
Otherwise good to go :D
good idea ! |
34fe2a7
to
4b50a88
Compare
algolia/api-clients-automation#817 Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#817 Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
A new version allows to simplify the call to the formatter, but I missed the update because renovate wasn't setup for it yet.