Skip to content

chore: From Flow to typescript #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

chore: From Flow to typescript #648

wants to merge 32 commits into from

Conversation

armandabric
Copy link
Collaborator

@armandabric armandabric commented Oct 2, 2021 •
edited
Loading

TODOs

  • Pass on all files to re-introduce line break lost during the automatic conversion (to limit the diff of the PR)
  • Fix unit test (jest vitest)
  • Rollback smoke test to JS files
  • Remove the // @ts-expect-error: flow to TS comments
  • Reconfigure ESLint (or configure Biome)
  • Reconfigure building: rollup/babel/typescrip (is babel still needed?) tsup
  • Ensure TS type are exported correctly
  • Fix smoke test
  • Delete tserrors.txt file
  • Release a new major beta version to test it
  • 🍻

@armandabric armandabric added the dependencies Pull requests that update a dependency file label Oct 2, 2021
@armandabric armandabric self-assigned this Oct 2, 2021
@armandabric armandabric force-pushed the typescript branch 2 times, most recently from ed3707c to 0e99e35 Compare October 3, 2021 11:39
@armandabric armandabric changed the title From Flow to typescript chore: From Flow to typescript Oct 3, 2021
@ghost
Copy link

ghost commented Jun 23, 2022

Hello @armandabric could we work on this together

armandabric
armandabric commented Jan 13, 2025
View reviewed changes
src/formatter/formatComplexDataStructure.ts Outdated
Comment on lines 13 to 11
value: Object | Array<any>,
value: Record<string, unknown> | Array<unknown>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@armandabric armandabric

Labels
dependencies Pull requests that update a dependency file help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@armandabric