-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group-id
parameter to GET /v2/transactions
#1647
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
- Coverage 69.44% 65.01% -4.44%
==========================================
Files 38 40 +2
Lines 7386 8111 +725
==========================================
+ Hits 5129 5273 +144
- Misses 1839 2402 +563
- Partials 418 436 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As discussed internally, this needs to make use of group index by conditionally removing LIMIT when filtering by group id. Query optimizer spends weeks (>2 seconds) on optimizing this query if TXN happens to be partitioned. CREATE INDEX txn_grp ON public.txn USING btree (((txn #>> '{txn,grp}'::text[]))) WHERE ((txn #>> '{txn,grp}'::text[]) IS NOT NULL); |
Summary
Issue: #135
This pull request adds the
group-id
parameter to the endpointGET /v2/transactions
(this feature has already been implemented for Nodely in AlgoNode#2).This new parameter is disabled by default.
Test plan
End-to-end tests have been added to
api/handlers_e2e_test.go
.