feat: send payment transaction with algokit core #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point, the local AlgoKit Core this is using is from algorandfoundation/algokit-core#81 |
CiottiGiorgio
changed the title
aorumbayev
reviewed
May 15, 2025
| import algosdk.transaction | ||
|
|
||
|
|
||
| def payment_through_core( |
There was a problem hiding this comment.
I think the name makes it seem like the outcome is a submitted payment txn while it only assembles it.
Suggested change
| def payment_through_core( | |
| def make_payment_txn( |
There was a problem hiding this comment.
Sure, I still want to make it clear that it goes through core (at least for now). Would build_payment_with_core be good?
CiottiGiorgio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(draft) PR to use AlgoKit Core when dealing with a
Paymenttransaction in utils.Companion PR of algorandfoundation/algokit-utils-ts#393