fix(panel): Close works after Stop when waiting for user input#324
Open
gilangjavier wants to merge 1 commit intoalibaba:mainfrom
Open
fix(panel): Close works after Stop when waiting for user input#324gilangjavier wants to merge 1 commit intoalibaba:mainfrom
gilangjavier wants to merge 1 commit intoalibaba:mainfrom
Conversation
Add abort support to ask_user tool. When Stop is clicked while waiting for user answer, the promise rejects with AbortError, causing the main loop to catch and set status to error. Panel then clears the waiting UI and the Close button appears and works as expected. Changes: - Add withAbortSignal helper in tools - Expose abortSignal in PageAgentCore - Improve AbortError detection - Add Panel#cancelWaitingForUserAnswer - Call cancel when status changes away from running Fixes alibaba#183
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(panel): close works after stop when waiting for user input
Add abort support to ask_user tool. When Stop is clicked while waiting for
user answer, the promise rejects with AbortError, causing the main loop to catch
and set status to error. Panel then clears the waiting UI and the Close button
appears and works as expected.
Changes:
Fixes #183