Skip to content

chore: add PAIMON_THIRDPARTY_MIRROR_URL env#19

Merged
lucasfang merged 8 commits intoalibaba:mainfrom
lucasfang:main
Dec 19, 2025
Merged

chore: add PAIMON_THIRDPARTY_MIRROR_URL env#19
lucasfang merged 8 commits intoalibaba:mainfrom
lucasfang:main

Conversation

@lucasfang
Copy link
Copy Markdown
Collaborator

Purpose

set PAIMON_THIRDPARTY_MIRROR_URL env is a more user friendly way to set THIRDPARTY_MIRROR_URL in cmake

Tests

API and Format

Documentation

Copilot AI review requested due to automatic review settings December 18, 2025 03:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces support for the PAIMON_THIRDPARTY_MIRROR_URL environment variable to provide a more user-friendly way to configure the mirror URL for third-party dependencies during CMake builds.

Key Changes:

  • Added environment variable check for PAIMON_THIRDPARTY_MIRROR_URL that sets THIRDPARTY_MIRROR_URL if the environment variable is defined
  • Maintains backward compatibility by defaulting to an empty string when the environment variable is not set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucasfang lucasfang requested a review from zjw1111 December 18, 2025 05:25
@lucasfang lucasfang requested a review from lxy-9602 December 18, 2025 09:13
Copy link
Copy Markdown
Collaborator

@lxy-9602 lxy-9602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lucasfang lucasfang merged commit 4c82276 into alibaba:main Dec 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants