chore: disable lumina and lucene by default#190
Merged
lxy-9602 merged 2 commits intoalibaba:mainfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the build configuration so Lumina (vector index) and Lucene (FTS index) are opt-in by default for local builds, while keeping CI coverage by explicitly enabling them in the CI build script.
Changes:
- Set
PAIMON_ENABLE_LUMINAdefault toOFF. - Set
PAIMON_ENABLE_LUCENEdefault toOFF. - Enable both options explicitly in CI via
ci/scripts/build_paimon.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CMakeLists.txt |
Switches Lumina/Lucene CMake options to default OFF to avoid building optional dependencies unless requested. |
ci/scripts/build_paimon.sh |
Forces Lumina/Lucene ON in CI builds so these features remain compiled and tested in workflows using this script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zjw1111
added a commit
to zjw1111/paimon-cpp
that referenced
this pull request
Mar 20, 2026
lxy-9602
pushed a commit
that referenced
this pull request
Mar 20, 2026
* chore: disable lumina and lucene by default (#190) * chore: update version to v0.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PAIMON_ENABLE_LUMINAdefault toOFFPAIMON_ENABLE_LUCENEdefault toOFF