fix(ut): prevent incorrect implicit conversion of string literals to …#24
Merged
lxy-9602 merged 3 commits intoalibaba:mainfrom Dec 22, 2025
Merged
fix(ut): prevent incorrect implicit conversion of string literals to …#24lxy-9602 merged 3 commits intoalibaba:mainfrom
lxy-9602 merged 3 commits intoalibaba:mainfrom
Conversation
|
|
lxy-9602
reviewed
Dec 21, 2025
Collaborator
|
LGTM |
lszskye
approved these changes
Dec 22, 2025
Contributor
Author
|
I don't have merge permissions. @lszskye @lucasfang, pls help it, thanks |
This was referenced Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bool
Purpose
Linked issue: close #xxx
when use gcc8, some ut failed because the implicit conversion from const char* to bool is qualified as standard conversion, while const char* to std::string is user-defined conversion. The former has higher ranking and wins in overload resolution.
Tests
API and Format
Documentation