Skip to content

add release ci workflow and remove global no-access-control#32

Merged
lucasfang merged 8 commits intoalibaba:mainfrom
lucasfang:fix-ci
Dec 24, 2025
Merged

add release ci workflow and remove global no-access-control#32
lucasfang merged 8 commits intoalibaba:mainfrom
lucasfang:fix-ci

Conversation

@lucasfang
Copy link
Copy Markdown
Collaborator

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

Copilot AI review requested due to automatic review settings December 23, 2025 09:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

test/inte/global_index_test.cpp:1679

  • The change from initializer list std::vector<std::string> values = {"parquet"}; to separate declaration and emplace_back adds unnecessary verbosity without providing any benefit. The initializer list syntax is more concise and equally efficient. This change appears unrelated to the PR's stated purpose of adding release CI workflow and removing global no-access-control flag.
    ASSERT_EQ(topk_result->ToString(), "row ids: {7}, scores: {0}");


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucasfang lucasfang requested a review from lxy-9602 December 24, 2025 06:21
Copy link
Copy Markdown
Collaborator

@lxy-9602 lxy-9602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lucasfang lucasfang merged commit 670a294 into alibaba:main Dec 24, 2025
9 of 10 checks passed
@lucasfang lucasfang deleted the fix-ci branch December 30, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants