add release ci workflow and remove global no-access-control#32
Merged
lucasfang merged 8 commits intoalibaba:mainfrom Dec 24, 2025
Merged
add release ci workflow and remove global no-access-control#32lucasfang merged 8 commits intoalibaba:mainfrom
lucasfang merged 8 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
test/inte/global_index_test.cpp:1679
- The change from initializer list
std::vector<std::string> values = {"parquet"};to separate declaration andemplace_backadds unnecessary verbosity without providing any benefit. The initializer list syntax is more concise and equally efficient. This change appears unrelated to the PR's stated purpose of adding release CI workflow and removing global no-access-control flag.
ASSERT_EQ(topk_result->ToString(), "row ids: {7}, scores: {0}");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lxy-9602
reviewed
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation