Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/clang_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
lfs: true
fetch-depth: 0 # fetch all history for git diff in clang-tidy
- name: Build Paimon
shell: bash
env:
Expand Down
2 changes: 1 addition & 1 deletion cmake_modules/DefineOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
"If on, only git-diff files will be passed to linting tools" ON)

define_option_string(PAIMON_LINT_GIT_TARGET_COMMIT
"target commit/branch for comparison in git diff" "HEAD")
"target commit/branch for comparison in git diff" "origin/main")

define_option(PAIMON_GENERATE_COVERAGE "Build with C++ code coverage enabled" OFF)

Expand Down
4 changes: 2 additions & 2 deletions src/paimon/common/global_index/global_index_result.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,13 @@ Result<std::vector<Range>> GlobalIndexResult::ToRanges() const {
// Extend the current range
range_end = current;
} else {
ranges.push_back(Range(range_start, range_end));
ranges.emplace_back(range_start, range_end);
range_start = current;
range_end = current;
}
}
// Add the last range
ranges.push_back(Range(range_start, range_end));
ranges.emplace_back(range_start, range_end);
return ranges;
}

Expand Down
4 changes: 2 additions & 2 deletions src/paimon/common/utils/range.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ std::vector<Range> Range::Exclude(const std::vector<Range>& ranges) const {
}
// Add the part before the intersection (if any)
if (current < intersect.value().from) {
result.push_back(Range(current, intersect.value().from - 1));
result.emplace_back(current, intersect.value().from - 1);
}
// Move current position past the intersection
current = intersect.value().to + 1;
Expand All @@ -132,7 +132,7 @@ std::vector<Range> Range::Exclude(const std::vector<Range>& ranges) const {
}
// Add the remaining part after all exclusions (if any)
if (current <= to) {
result.push_back(Range(current, to));
result.emplace_back(current, to);
}

return result;
Expand Down
Loading