Make module more robust with default parameter #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qiaozp <[email protected]>
…iggest chance to success Signed-off-by: Qiaozp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did I do
Now we have to specify the master and worker node type. This PR enable the module to work without those param and have most chance to success.
How did I do it
When user don't specify the
master_instance_typesandworker_instance_types, module will find the zone_id which support most ECS types and find suited ECS type to create ACK.How this is tested
Test screenshot, using examples/complete directory:
Signed-off-by: Qiaozp [email protected]