Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_gpdb_db_instance_plan: add new attribute scale_up, scale_down; resource/alicloud_gpdb_instance: add new attribute parameters. #7698

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

The-Seagull-like
Copy link
Contributor

resource/alicloud_gpdb_db_instance_plan: add new attribute scale_up, scale_down; resource/alicloud_gpdb_instance: add new attribute parameters.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@@ -69,7 +69,6 @@ func resourceAliCloudGpdbDbInstancePlan() *schema.Resource {
"plan_config": {
Type: schema.TypeList,
Required: true,
MaxItems: 1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里现在可以配置多个了吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确切来说,如果计划为postpone类型,属于一次性计划,那么pause,resume,scale_in,scale_out,scale_up,scale_down只能有1个

如果计划为regular类型,属于周期计划,那么pause/resume结对出现,scale_in/scale_out结对出现,scale_up/scale_down结对出现

@@ -112,6 +112,8 @@ The plan_config supports the following:
* `pause` - (Optional, Set) Pause instance plan config. See [`pause`](#plan_config-pause) below.
* `scale_in` - (Optional, Set) Scale In instance plan config. See [`scale_in`](#plan_config-scale_in) below.
* `scale_out` - (Optional, Set) Scale out instance plan config. See [`scale_out`](#plan_config-scale_out) below.
* `scale_up` - (Optional, Set) Scale up instance plan config. See [`scale_up`](#plan_config-scale_up) below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一下可用版本信息 Available since v1.231.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已订正


* `name` - (Required) The name of the parameter.
* `value` - (Required) The value of the parameter.

## Attributes Reference

The following attributes are exported:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只读属性在底下需要声明出来

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已订正

@The-Seagull-like The-Seagull-like force-pushed the feature/adbpg_plan branch 7 times, most recently from 0c94ad7 to b489aca Compare September 25, 2024 07:45
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@The-Seagull-like The-Seagull-like force-pushed the feature/adbpg_plan branch 4 times, most recently from b79735d to f3385a1 Compare September 26, 2024 09:16
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@The-Seagull-like The-Seagull-like force-pushed the feature/adbpg_plan branch 3 times, most recently from 1889b5d to 279ec22 Compare September 26, 2024 14:37
@The-Seagull-like
Copy link
Contributor Author

Test result:
image

…scale_down; resource/alicloud_gpdb_instance: add new attribute parameters.
@ChenHanZhang ChenHanZhang merged commit 3ccd688 into aliyun:master Sep 27, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants